Repository navigation
docs(readme): make every claim true and current - #11
Merged
Merged
Conversation
- correct DEFAULT_TENANT_ID, DATABASE_URL, REDIS_URL, CONTAINERS_SERVICE_URL and the OpenTelemetry defaults against src/config/settings.py - describe the trusted-CIDR tenant fallback and the production-required URLs - document every Settings field; Redis is required in production, not optional - fix the local-run command and replace the stale registry/CI description Co-Authored-By: Claude Code <noreply@anthropic.com> Signed-off-by: georgiedekker <georgiedekker@gmail.com>
nonagenticai-claude
Bot
requested a review
from georgiedekker
as a code owner
November 15, 2026 08:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
README-only. Corrects the configuration table, tenant fallback description, local-run command and CI description.
Corrections and proof
DEFAULT_TENANT_IDdefaultn8n-devsrc/config/settings.pyhas nodefault_tenant_idfield (see the comment where it would be);.venv/lib/python3.14/site-packages/coding_client/auth/_default_tenant.py—os.getenv("DEFAULT_TENANT_ID", "").strip() or None, i.e.Nonewhen unsetcoding_client/auth/_default_tenant.py(resolve_default_tenant);src/auth/tenant.pyre-exports the SDK middlewareDATABASE_URLdefaultpostgresql+psycopg://...""src/config/settings.py—database_url: str = ""REDIS_URLdefaultredis://redis:6379/0""src/config/settings.py—redis_url: str = ""CONTAINERS_SERVICE_URLdefaulthttp://coding-containers:8691""src/config/settings.py—containers_service_url: str = ""OTEL_EXPORTER_OTLP_ENDPOINTOTEL_ENDPOINT=""(present, unwired) +OTLP_TRACES_ENDPOINT(unset, actual)src/config/settings.pyotel_endpoint;.venv/.../coding_client/telemetry.py:156readsOTLP_TRACES_ENDPOINTsrc/config/settings.py_REQUIRED_IN_PRODUCTION = ("database_url", "redis_url", "containers_service_url", "docker_registry_url")_REQUIRED_IN_PRODUCTION;src/app_factory.py:39-112;src/services/scan_queue.pySettingsfields (core + scanning/worker tables)src/config/settings.py; checked programmatically that every field appearsSCAN_MAX_DELIVERIESdead-letters;SCAN_STREAM_MAXLENcaps the streamsrc/services/scan_worker.py:20,180;src/services/scan_queue.py:131uv run uvicorn main:app ...ENVIRONMENT=testing PYTHONPATH=src uv run uvicorn main:app ...src/main.py;Dockerfile:234setsPYTHONPATH=/app/src; import verified locally with that environment192.168.1.114:5000/..., promoted to:latestghcr.io/nonagenticai/coding-security, no deploy job, weekly rebuild.github/workflows/ci.ymlrouters/security.pyrouters/security/src/routers/security/NOTICEstill referencedREADME.md## Licensing+## License;NOTICEVerification
git diff --stat—README.mdonly (71 insertions, 25 deletions).ruff check,ruff format --check,ty@0.0.104 check src, fullpytest.n8n-devtext now explains that no such fallback exists.🤖 Generated with Claude Code