Repository navigation
fix(types): pass ty 0.0.104 - #8
Merged
Merged
Conversation
- rename ignore-comment rule invalid-mutable-override to incompatible-mutable-override (renamed in ty 0.0.104) - rename [tool.ty.rules] unresolved-import to import-not-found - _install_packages_with_retry: guard package_manager is not None before use instead of reading .value off a possible None (missing-union-attribute) - annotate ecosystems as set[Literal["pypi", "crates.io"]] so the "auto" branch keeps its literal element type Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
nonagenticai-claude
Bot
requested a review
from georgiedekker
as a code owner
November 14, 2026 09:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepares this repo for the shared CI archetype bump from ty 0.0.39 to ty 0.0.104. Before this change
uvx ty@0.0.104 check srcreported 8 diagnostics.Diagnostics fixed
warning[renamed-rule-in-ignore-comment]x6 —invalid-mutable-overriderenamedsrc/models/errors.py(lines 102, 143, 159, 175, 191, 211)# ty: ignore[...]comments toincompatible-mutable-override. Same suppression, current rule name.warning[renamed-rule]—unresolved-importrenamedpyproject.toml[tool.ty.rules]import-not-found(ty's current name for the same rule).error[missing-union-attribute]—Attribute 'value' is not defined on 'None' in union 'Unknown | None'src/services/system_dependency_manager.py:831_install_packages_with_retrynow returnsFalsewith an error log whenself.package_managerisNone, before touching.value. This matches the existing guard idiom in_install_dependencies. The oldelsebranch is now only reachable with a non-None manager, so its redundantif self.package_manager else "unknown"was simplified (this also clears theredundant-conditiondiagnostic the guard introduced).Also included (local gate only)
invalid-argument-typeatsrc/routers/security/dependency_inventory.py:287— ty 0.0.104 does not report it, but the repo's mandatory local pre-push hook (still pinned to ty 0.0.39, mirroring the archetype before this bump) fails on it locally and therefore blocked the push. Fixed by annotatingecosystems: set[Literal["pypi", "crates.io"]], which is what the value actually is at runtime; both ty versions are clean with it. It is behaviour-preserving.Verification
uvx ty@0.0.104 check src— All checks passed!uv run ruff check .— All checks passed!uv run ruff format --check .— 193 files already formatted🤖 Generated with Claude Code