Repository navigation
Express fixes for the release - #6
Merged
Merged
Conversation
Ubuntu 24.04 ships pandoc 3.1.3, which predates the gfm alerts extension (3.1.10): > [!NOTE] callouts were built as literal blockquotes, so yeti.lua never turned them into styled alerts on the web, and the release PDF/MD hit the same path. Install the official 3.12.1 tarball instead of the apt package in page, publish and readme; publish keeps apt for texlive and librsvg.
persist-credentials: false leaves add-and-commit's git push with no credentials (its github_token input is API-only), so re-add the auth header checkout omits before the commit step.
Two root causes made the site unusable on phones:
- The contents was a Yi/e/Yeti .card, whose author rule (display: flex)
outranks the user-agent rule that hides a closed popover, so the shut
drawer painted as a full-screen card over the page. Declare the closed
state explicitly (#toc:not(:popover-open) { display: none }) and keep
the sticky sidebar only from 64rem up.
- The build minifier escapes "<" inside inlined CSS, deleting whole
@media (width < Nrem) blocks; the hamburger vanished on landscape
phones and tablets. Rewrite every condition in the "at least" form so
it survives minification.
Also hide the nav actions (GitHub, Download PDF) below 48rem so the brand
and hamburger fit, and drop leftover draft CSS from style.css.
Two root causes made the site unusable on phones:
- The contents was a Yeti .card, whose author rule (display: flex)
outranks the user-agent rule that hides a closed popover, so the shut
drawer painted as a full-screen card over the page. Declare the closed
state explicitly (#toc:not(:popover-open) { display: none }) and keep
the sticky sidebar only from 64rem up.
- The build minifier escapes "<" inside inlined CSS, deleting whole
@media (width < Nrem) blocks; the hamburger vanished on landscape
phones and tablets. Rewrite every condition in the "at least" form so
it survives minification.
Also hide the nav actions (GitHub, Download PDF) below 48rem so the brand
and hamburger fit, and drop leftover draft CSS from style.css.
…2_MiniLibX_Python_Manual into express-fixes-for-the-release
Contributor
Super-linter summary
All files and directories linted successfully For more information, see the GitHub Actions workflow run Powered by Super-linter |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes and hardening for the release: repairs the mobile layout of the web manual template and makes the release pipeline actually chain all its workflows when release-please creates a tag with
GITHUB_TOKEN(which GitHub does not propagate to push/release events).Type of Change
Changes Made
src/template/web/):popoverbutton visible below64rem(Yeti's own nav rules dropped it between32rem–64rem, stranding the drawer on landscape phones/small tablets).48remand show them from there up, replacing[data-show="lg"], whose container query the build minifier mangles.#tocpopover staying visible on phones (#toc:not(:popover-open) { display: none }), since the.cardauthor rule outranked the user-agent rule.width >= X) so the minifier can't escape<and drop the block.--yeti-space-smand drop the redundant dark-modebox-shadowoverride.src/template/md.tex,src/template/readme_md.tex): add centered links to both the PDF version (GitHub releases) and the web version of the manual./.github/workflows/):release-please.yml: exposerelease_created/tag_nameoutputs and explicitly chainpublish,pageandreadmeviaworkflow_call(tags made withGITHUB_TOKENdon't trigger tag/release events); move permissions to job level withpermissions: {}at workflow level (zizmor).publish.yml/page.yml/readme.yml: acceptworkflow_call(plusworkflow_dispatchwhere useful);publishtakes the release-pleasetaginput fortag_name.alertsextension, so> [!NOTE]callouts shipped as literal text).astral-sh/setup-uvto a commit hash and disable its cache;page.ymlnow builds onlymake weband drops texlive from the Pages deploy;publish.ymlbuildsmake pdf markdown.readme.yml: restore the auth header forEndBug/add-and-commit(checkout runs withpersist-credentials: false, so its plain-git push had no credentials).How to Test
make web, servedist/) on a phone-sized viewport: the hamburger must open the contents drawer, the closed drawer must not cover the page, and the GitHub/PDF buttons must only appear from48remup (also check a landscape phone, between32remand64rem).make markdownoutput: the centered "PDF Version" / "Web Version" links appear and point to the releases page and https://mlx-manual.nora.defitero.com/.mainand confirm release-please, on creating a release, chains publish (PDF+MD attached to the release), Pages deploy and README update in the same run; verify pandoc 3.12.1 renders> [!NOTE]callouts in the README.Checklist
Related Issues
Screenshots