Skip to content

chore(contract): 契約スナップショットを notedeck develop に更新し、クエリ検証手順を回帰テストに寄せる - #84

Merged
hitalin merged 1 commit into
mainfrom
chore/contract-sync-develop
Oct 13, 2026
Merged

hitalin merged 1 commit into
mainfrom
chore/contract-sync-develop

Conversation

@hitalin

@hitalin hitalin commented Oct 13, 2026

Copy link
Copy Markdown
Collaborator

なぜ

notedeck の develop に capability の追加・拡張が入った (notedeck-dev/notedeck#1244 / #1245 / #1247 / #1248 / #1242 / #1252)。契約スナップショットを追従させ、既存の配布物が壊れていないことを確かめる。あわせて、配布クエリの検証が notedeck 側の回帰テスト (notedeck-dev/notedeck#1254) になったので、手順のドキュメントを直す。

変更

  • 契約スナップショットを notedeck develop (3fffc229) から取り直した。差分は commands.list の追加だけ (既存 capability の id・権限・実行属性は不変)
  • docs/query-coverage.md: 一時テストを手で置く運用をやめ、notedeck で pnpm gen:golden-misstore を回して取り直す手順にした

確認

pnpm contract:verify: 148 件中、合格 148 / 不合格 0 (警告 9 件は既存の Misskey scope 形式の件)。

含めないもの

新しい capability を使う形への配布物の移行 (note-context / reply-queue / thread-to-memo / keybinds-cheatsheet / federation-radar / plugin-auditor など)。notedeck のリリース前に入れると、今のアプリでは動かなくなるため、リリース後に minNoteDeckVersion を上げて行う。

🤖 Generated with Claude Code

…を回帰テストに寄せる

- スナップショット: commands.list の追加を取り込む (他の capability の id・権限は不変)。
  契約チェックは 148 件すべて合格
- docs/query-coverage.md: 配布クエリの検証は notedeck の回帰テスト (notedeck#1254) に
  なったので、手で一時テストを置く代わりに pnpm gen:golden-misstore で取り直す手順にする

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 13, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 26 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 99b4d58f-bc83-4106-b395-a9e70c50fd21
📥 Commits

Reviewing files that changed from the base of the PR and between 3c9da14 and 516cad5.

📒 Files selected for processing (2)
  • docs/query-coverage.md
  • scripts/contract/notedeck-contract.json
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@hitalin
hitalin merged commit 81a69ab into main Oct 13, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant