Repository navigation
feat(skills): アカウント別の配色スキル account-accent を追加 - #86
Merged
Merged
Conversation
複数アカウントの誤爆を防ぐため、アカウントごとに accent だけを変えた派生 テーマを作り、そのアカウントのカラムだけに当てる。NoteDeck 1.85.0 の themes.apply の accountId を使う。 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
⛔ Files ignored due to path filters (1)
📒 Files selected for processing (9)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Collaborator
Author
|
@coderabbitai review |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
なぜ
NoteDeck v1.85.0 で
themes.applyがaccountIdを受けるようになり、テーマをそのアカウントのカラムだけに当てられるようになった (notedeck-dev/notedeck#1247)。複数アカウントを使う人が、どのアカウントのカラムかを色でひと目で見分けられるようにする (誤爆防止)。内容
スキル
account-accent(アカウント別の配色、0.1.0)。themes.createで作るthemes.apply({ id, accountId })で当てる。themes.applyは確認ダイアログが出ずにすぐ反映されるため、先に一覧を見せる。accountIdを付け忘れるとデッキ全体が変わる旨も明記themes.update) を案内する検討して出さなかったもの
期限つきミュートのプラグインも作ったが出さない。本家 Misskey Web はミュート時に期間を選べる標準機能なので、NoteDeck 本体の機能として足す (notedeck-dev/notedeck#1260)。
確認
registry:build/ レジストリ完全性チェック OKpnpm contract:verify: 149 件中、合格 149 / 不合格 0🤖 Generated with Claude Code