[PrashantBtkl]

Description

In pkg/ws/client.go at line 122 within Client.Run, websocket disconnect errors returned by connectAndServe(ctx) are logged at ERROR level with c.logger.Error("websocket session ended", "err", err). Because websocket disconnections are part of normal operational cycles handled cleanly via exponential backoff reconnection, logging at ERROR level causes Prometheus alert ForagerServiceLogErrors to trigger erroneously.

This change demotes the log level from Error to Warn (c.logger.Warn("websocket session ended", "err", err)), retaining visibility of session terminations without incrementing error log metrics (container_log_messages_total with level="error").

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Enhancement (non-breaking change which improves existing functionality)
• Refactor (non-breaking change which improves code structure)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation
• CI/CD

Original Error/Logs

Click to expand the original error that triggered this fix

In pkg/ws/client.go at line 122, change the log level for returned connection errors in Client.Run from c.logger.Error("websocket session ended", "err", err) to c.logger.Warn("websocket session ended", "err", err). Incident evidence shows the forager service remains healthy and automatically reconnects using exponential backoff, but logging at ERROR level triggers Prometheus alert ForagerServiceLogErrors. Regression check: verify that disconnect and reconnect cycles emit WARN level logs without incrementing container_log_messages_total with level="error".

How Has This Been Tested?

• Unit tests
• Manual testing

Checklist

• CLA signed (the CLA bot will prompt on your first PR)
• make validate passes (fmt + lint + test)
• Docs updated if the wire shape, config surface, or proxy module behavior changed

---

🤖 This PR was automatically generated by NudgeBee AI coding agent

Powered by AI-driven code analysis and automated fix generation

🔍 View Original Investigation

Click the link above to see the full investigation and analysis that led to this fix

View Detailed Nubi Conversation

[gemini-code-assist]

Code Review

This pull request updates the log level from Error to Warn when a websocket session ends in pkg/ws/client.go. The reviewer recommends checking if the context has been cancelled before logging the warning to prevent false positives in log monitoring during normal shutdowns or restarts.

[gemini-code-assist]

During a clean shutdown (when the context is cancelled), connectAndServe will return an error due to the connection being closed. Logging this as a warning can lead to false positives in log monitoring during normal deployments or restarts. Consider checking if the context has been cancelled before logging the warning.

Suggested change

	if err != nil {
	c.logger.Error("websocket session ended", "err", err)
	c.logger.Warn("websocket session ended", "err", err)
	}
	if err != nil && ctx.Err() == nil {
	c.logger.Warn("websocket session ended", "err", err)
	}

[nudgebee-dev]

Nudgebee Automated Followup

During clean shutdown or service restarts, context cancellation terminates websocket connections, causing connectAndServe to return context.Canceled. Demoting log levels to Warn still emits warnings unless ctx.Err() is verified to be nil. Additionally, CI govulncheck failures related to the Go toolchain version in go.mod require updating the Go directive to 1.26.10.

Commit: f696387e785d

[nudgebee-dev]

Nudgebee Automated Followup

I reviewed the open comment(s) on this PR but couldn't automatically apply a change in this run.

What I looked at: The PR demoted websocket session disconnect logging in pkg/ws/client.go from Error to Warn to avoid triggering false-positive Prometheus alerts (ForagerServiceLogErrors) during normal reconnections. Code review comment #4335828999 requested checking ctx.Err() == nil to prevent warnings on clean shutdown/cancellation, which was already applied in the latest commit. Local validation make validate passes cleanly with zero issues.

No code was changed. If this needs a manual edit, please apply it directly.