Repository navigation
fix: lower websocket session ended log severity from Error to Warn in Client.Run - #174
Open
nudgebee-dev[bot] wants to merge 1 commit into
Open
nudgebee-dev[bot] wants to merge 1 commit into
nudgebee-dev[bot] wants to merge 1 commit into
Conversation
… Client.Run
# Description
In `pkg/ws/client.go` within the `Client.Run` reconnection loop, session termination errors returned by `c.connectAndServe(ctx)` are logged at `Error` severity (`c.logger.Error("websocket session ended", "err", err)`). During transient disconnects or routine connection renegotiation with the relay, the client automatically recovers via exponential backoff reconnects. However, logging at `Error` severity increments `container_log_messages_total{level="error"}` and triggers benign `ForagerServiceLogErrors` Prometheus alerts.
This change demotes the log severity from `Error` to `Warn` (`c.logger.Warn("websocket session ended", "err", err)`), avoiding triggering benign alerts while preserving visibility into session terminations.
## Type of change
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Enhancement (non-breaking change which improves existing functionality)
- [ ] Refactor (non-breaking change which improves code structure)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation
- [ ] CI/CD
## Original Error/Logs
<details>
<summary>Click to expand the original error that triggered this fix</summary>
```
Change log severity for websocket session ended from Error to Warn in Client.Run reconnection loop. PR #172 in nudgebee/forager already implements this fix.
Files located during the investigation: pkg/ws/client.go
The investigation already read this code:
**Code examined**
- `pkg/ws/client.go`:120-123 — Logs websocket session termination at Error level during Client.Run reconnect loop
```
err := c.connectAndServe(ctx)
if err != nil {
c.logger.Error("websocket session ended", "err", err)
}
```
If part of the requested change is already present in the code above, do not repeat it: implement the part that is missing. If the whole request is already satisfied, make no change and report that, citing the code that satisfies it.
```
</details>
# How Has This Been Tested?
- [x] Unit tests
- [ ] Manual testing
# Checklist
- [ ] CLA signed (the CLA bot will prompt on your first PR)
- [x] `make validate` passes (fmt + lint + test)
- [ ] Docs updated if the wire shape, config surface, or proxy module behavior changed
---
🤖 **This PR was automatically generated by [NudgeBee](https://nudgebee.com) AI coding agent**
*Powered by AI-driven code analysis and automated fix generation*
🔍 **[View Original Investigation](https://dev.nudgebee.pollux.in/investigate?id=f511cca4-a6fe-4426-aeb3-48e3dfce7cc9)**
*Click the link above to see the full investigation and analysis that led to this fix*
View Detailed **[Nubi Conversation](https://dev.nudgebee.pollux.in/ask-nudgebee?accountId=f13ddc45-07f3-42b4-bd0e-19606c852d18&session_id=event-4e4fee2c9ba759b6)**
---
### ✅ Verification
Build verification passed for the affected modules.
<details><summary>Commands run</summary>
```
PASSED (cd . && go build ./...) exit=0
```
</details>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In
pkg/ws/client.gowithin theClient.Runreconnection loop, session termination errors returned byc.connectAndServe(ctx)are logged atErrorseverity (c.logger.Error("websocket session ended", "err", err)). During transient disconnects or routine connection renegotiation with the relay, the client automatically recovers via exponential backoff reconnects. However, logging atErrorseverity incrementscontainer_log_messages_total{level="error"}and triggers benignForagerServiceLogErrorsPrometheus alerts.This change demotes the log severity from
ErrortoWarn(c.logger.Warn("websocket session ended", "err", err)), avoiding triggering benign alerts while preserving visibility into session terminations.Type of change
Original Error/Logs
Click to expand the original error that triggered this fix
err := c.connectAndServe(ctx)
if err != nil {
c.logger.Error("websocket session ended", "err", err)
}
How Has This Been Tested?
Checklist
make validatepasses (fmt + lint + test)🤖 This PR was automatically generated by NudgeBee AI coding agent
Powered by AI-driven code analysis and automated fix generation
🔍 View Original Investigation
Click the link above to see the full investigation and analysis that led to this fix
View Detailed Nubi Conversation
✅ Verification
Build verification passed for the affected modules.
Commands run