Conversation
tmakatos
added this pull request to stack #71
October 1, 2026 12:18
tmakatos
force-pushed
the
arm_cooldown_revert
branch
from
October 1, 2026 16:23
3214afa to
928b71f
Compare
tmakatos
force-pushed
the
arm_cooldown_revert
branch
from
October 1, 2026 16:35
928b71f to
abcfefa
Compare
tmakatos
force-pushed
the
arm_cooldown_revert
branch
from
October 1, 2026 16:42
abcfefa to
ae5a255
Compare
tmakatos
force-pushed
the
arm_cooldown_revert
branch
from
October 2, 2026 05:05
ae5a255 to
af03e19
Compare
Revert did not arm cooldown, so the next poll could immediately re-apply Up/Down and undo the rollback. Treat revert like other actuations for cooldown, while still allowing revert itself to bypass an existing cooldown so a failed scale can roll back. AI-generated: everything, manual fixup of commit message Signed-off-by: Thanos Makatos <thanos.makatos@nutanix.com>
tmakatos
force-pushed
the
arm_cooldown_revert
branch
from
October 2, 2026 06:31
af03e19 to
3523070
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert did not arm cooldown, so the next poll could immediately re-apply
Up/Down and undo the rollback.
Treat revert like other actuations for cooldown, while still allowing
revert itself to bypass an existing cooldown so a failed scale can
roll back.
AI-generated: everything, manual fixup of commit message
Signed-off-by: Thanos Makatos thanos.makatos@nutanix.com
Stack created with GitHub Stacks CLI • Give Feedback 💬