Editable Power Factor and Nominal VA for watts calculation - #241
Open
merodahero wants to merge 2 commits into
Open
Editable Power Factor and Nominal VA for watts calculation#241merodahero wants to merge 2 commits into
merodahero wants to merge 2 commits into
Conversation
Adds two new settings under the existing CAL namespace:
- CAL_PowerFactor (Double, default 0.95)
- CAL_ApparentPowerNom (Int32, default 2400)
The Schneider Easy UPS SRVSPM3KIL (and many other online-double-
conversion units) does not publish ups.realpower through the apcsmart
driver, so WinNUT-Client falls back to its computed methods. The
hardcoded POWER_FACTOR = 0.8 in UPS_Device.vb under-reads by ~15%.
The new settings let users override both:
- POWER_FACTOR feeds OutputVACalc and InputNomVALoadPct
- CAL_ApparentPowerNom backs up RPNomLoadPct when the unit does
not publish ups.realpower.nominal
Defaults are tuned for online-double-conversion UPSes. To keep the
Common assembly free of My.Settings (which is scoped to the Client
project only), the values flow through a public shared
UPS_Device.RuntimeConfig class that the Client project populates
from My.Settings at UPS_Device instantiation.
Wire-frame in Pref_Gui: two new NumericUpDown controls (PF:
0.00–1.00, ApparentNomVA: 0–100000) added to the existing CAL tab.
Contributor
|
Hi @merodahero, any particular reason you closed this PR? It's a requested feature by our users and something I was looking forward to merging. Thank you for the work regardless though. |
Author
|
@gbakeman i was just playing around and didnt think it would be needed :D ill re open |
…ference Restores NuGet resolution for .NET Framework 4.x targets on modern NuGet clients (5.0+). Both vbproj files were missing the explicit PackageReference, causing intermittent NU1605 'No warning' / NU1701 errors during restore on systems where the legacy GAC fallback isn't available. The 1.0.3 version is the latest stable; matches the locked assembly versions referenced elsewhere in the project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(client): editable Power Factor and Nominal VA for watts calculation
Adds two new settings under the existing CAL namespace:
The Schneider Easy UPS SRVSPM3KIL (and many other online-double-
conversion units) does not publish ups.realpower through the apcsmart
driver, so WinNUT-Client falls back to its computed methods. The
hardcoded POWER_FACTOR = 0.8 in UPS_Device.vb under-reads by ~15%.
The new settings let users override both:
not publish ups.realpower.nominal
Defaults are tuned for online-double-conversion UPSes. To keep the
Common assembly free of My.Settings (which is scoped to the Client
project only), the values flow through a public shared
UPS_Device.RuntimeConfig class that the Client project populates
from My.Settings at UPS_Device instantiation.
Wire-frame in Pref_Gui: two new NumericUpDown controls (PF:
0.00–1.00, ApparentNomVA: 0–100000) added to the existing CAL tab.