Repository navigation
Conversation
error.vue now sets the docus-sub-header class like app.vue, and the 112px header height rule moved into the layer global CSS so both templates share it.
|
@shkomg is attempting to deploy a commit to the NuxtLabs Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1438
With
navigation.sub: 'header', a missing page under an existing section rendered the error page with the two-row header squeezed into 64px, becauseerror.vuelacked thedocus-sub-headerwrapper class thatapp.vuesets.error.vuecallsuseSubNavigation(navigation)and adds the samedocus-sub-headerclass to its wrapper, so the variable sits on the common ancestor of the header and the error content, like inapp.vue.@media (min-width: 1024px) { .docus-sub-header { --ui-header-height: 112px } }rule moved from the<style>block inapp.vueinto the layer'sdocus.csstemplate, so it also applies when only the error template renders.Checked in the playground with
navigation.sub: 'header'at 1280px:/docs/getting-started/does-not-existnow has a 112px header (64px before), on direct load and after client-side navigation; normal docs pages are unchanged at 112px, and below 1024px the header stays 64px. ESLint on the changed files, typecheck and unit tests pass.The video shows the playground with the header tab bar enabled, opening a missing page under Getting Started, where the error page header now matches the other pages.
docus.mp4
Fix written with Claude Code; video is an automated browser run of this branch recorded by User Stories Bot.