Skip to content

Use new Slack API to post failure to Slack channel - #241

Merged
Leonidas-from-XIV merged 1 commit into
ocaml-dune:mainfrom
Leonidas-from-XIV:fix-slack-notification
Sep 23, 2026
Merged

Leonidas-from-XIV merged 1 commit into
ocaml-dune:mainfrom
Leonidas-from-XIV:fix-slack-notification

Conversation

@Leonidas-from-XIV

Copy link
Copy Markdown
Contributor

Currently the action fails because the channel ID is supposedly wrong. It isn't, I've updated it and it's still failing.

However the action used is quite old and outdated, so this PR re-creates the same action but using the (current at the time of writing) GH action from Slack.

I've created the required app and tokens in the repository settings.

@shonfeder shonfeder left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for catching this!

Has this solution been tested somewhere?

Currently the action fails because the channel ID is supposedly wrong.
It isn't, I've updated it and it's still failing.

However the action used is quite old and outdated, so this PR re-creates
the same action but using the (current at the time of writing) GH action
from Slack.

I've created the required app and tokens in the repository settings.

Signed-off-by: Marek Kubica <marek@tarides.com>
@Leonidas-from-XIV

Copy link
Copy Markdown
Contributor Author

I've tested it now, on my fork. In this workflow run the deployment step fails (because my fork does not have credentials), but the notify step succeeds now and it posts correctly to our Slack channel.

@Leonidas-from-XIV
Leonidas-from-XIV merged commit 0ca875b into ocaml-dune:main Sep 23, 2026
3 checks passed
@Leonidas-from-XIV

Copy link
Copy Markdown
Contributor Author

I've merged it and also removed the old unused Slack secrets from the action so they won't cause confusion in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants