Fix expiring-items note: deliveries are filtered to completed only

[amjithtitus09]

Smoke-testing the Analytics SQL Reviewer workflow end-to-end after the JIRA credential fix — this PR is the trigger, and the change itself is a genuine (small) documentation fix rather than throwaway content.

The fix

Care/Inventory/expiring_items.md claimed in its Notes:

Only products with status = 'active' and supply deliveries in completed / in_progress status are included.

But the query filters on sd.status = 'completed' alone, so in_progress deliveries never appear. The note now matches the query, and the Last updated stamp is refreshed.

Why this PR exists

The reviewer's delivery path (submit_pull_request_review) has never actually posted, because it was only ever exercised via workflow_dispatch, which carries no PR context to post into. Everything upstream is now verified working:

• bash -e bug in the JIRA step — fixed in Fix analytics-review pre-steps: survive Actions' bash -e; JIRA cloudId recovery via _edge/tenant_info #153
• PR context resolution — fixed in Fix analytics-review on workflow_dispatch: pass resolved PR context to the agent #152
• JIRA 404/401 — root-caused to a scoped token paired with the *.atlassian.net host, where scoped tokens are silently ignored; secret swapped to the unscoped token and confirmed with jira-ticket.md written for ENG-909

The branch name carries ENG-909, so this run exercises ticket context too.

Expected: the reviewer posts a consolidated review on this PR. That's the last unverified hop.

Close once the review lands — or merge it, since the doc fix stands on its own.

[github-actions]

Analytics SQL Review — expiring_items.md Notes fix

Lens 1 — Requirement fidelity: This PR does not implement JIRA ENG-909. That ticket asks to make the Total inventory query product-knowledge level (dropping batch-level split) — a different query entirely. This PR only corrects a stale Notes line in Care/Inventory/expiring_items.md. The branch name is amjithtitus09-eng-909-reviewer-smoketest, and the PR description confirms this is an intentional smoke test of the reviewer workflow, not a delivery of the ticket. Flagging per Lens 1 so it's explicit: no query in this PR addresses ENG-909 requirements (product-knowledge grain, no batch split). If ENG-909 is still open, it needs a separate PR.

Lens 2 — SQL correctness: No SQL changed in this diff — only the Notes prose. The query itself (unchanged) filters sd.status = 'completed' only; the corrected sentence now accurately reflects that (previously the note incorrectly said completed/in_progress were both included). Verified against the query body: no in_progress reference anywhere. Change is accurate.

Lens 3 — Documentation conformance: Doc now matches code; Last updated stamp bumped to today. No other TEMPLATE.md sections touched or affected.

Lens 4 — Repo hygiene: Single file, correct domain folder (Care/Inventory/), no unrelated changes.

Verdict: The doc correction itself is accurate and safe to merge — it fixes a real discrepancy between prose and query. Numbers/behavior of the query are unchanged (this is a comment-only fix), so nothing here affects dashboard trustworthiness. Separately, ENG-909 itself still appears undelivered based on the ticket description — worth confirming that's expected before closing the ticket.

Generated by Analytics SQL Reviewer for #156 · auto · 21.9 AIC · ⌖ 3.02 AIC · ⊞ 14.7K

[amjithtitus09]

Closing — this was a smoke test to verify the Analytics SQL Reviewer's delivery path end-to-end after the JIRA credential fix. The reviewer posted successfully (all five jobs green), so the workflow is confirmed working. The doc correction itself is not being merged.