[thisisgm]

A pass over how the files, the details pane, dialogs and the shortcut sheet read, so the accent marks only where the keys are and what is selected, and nothing important is cut or hidden. One commit per change; each says what was wrong and what it does now. The suite goes from 196 to 206 tests, and every test it adds passes with TMPDIR set to a folder with a space in its name.

What you'd notice in the files

• The selected name reads. It was accent text on the accent tint, dimmer than the names around it (3.8:1 on osaka-jade). It is now the bright text color, and its size and date the normal one, as a lit menu row does.
• The cursor stays in sight. Moving it by key past the edge of the grid, the list or a column left it out of view; the view now scrolls just enough to show it.
• The cursor shows when nothing is selected. After Alt+click on the last selected item, Delete, F2 and Return still act on the cursor's item, which now carries a thin accent frame.
• The pane without the keys is quiet. In a split both panes drew their selection in the accent. The pane the keys don't go to now draws its selection and cursor in a neutral tint, and a right click in it gives it the keys first, so Delete and F2 after the menu act on the file you clicked.
• Search results are named by their file. A result was named by its whole path, so deep results led with folders and cut their own names. Each now shows its name, with its folder quieter beside or under it; a tile led by its folder drops the date it had no room for. While the caret is in the search field, or Tab has put the keys in the sidebar or the details, the selection is drawn neutral, since the keys are not on it.
• The notice line keeps the folder. It elided its end, which is where a restore names the folder it put the file back in; it now elides the middle.

The details pane

• Several selected says so. It now says how many are selected and their size together, or how many are folders, under a plain glyph, with no one file's picture, details or Open button; several of a plugin's items get the plain glyph too. A selection with no cursor is counted too, instead of "Nothing selected".
• Titles and text previews wrap between words, splitting a word only when it is wider than the pane.
• Dates read "4:04 PM", not "4:04PM". Qt's en_US time puts a narrow no-break space before AM and PM, which the font draws as none. Format.js swaps it for a plain space, and the details pane's date goes through it too.
• "Nothing selected" lines up with "This folder is empty" beside it.

Dialogs, menus and the shortcut sheet

• A dialog dims the whole window. Rename, delete, mount, name clash and format dialogs were drawn inside their pane, so in a split, and beside the details pane, the rest stayed lit. They now dim everything, no pane takes keys while one is open, and the keys go back to the pane when the last one closes.
• The shortcut sheet shows its scroll bar. Its bar showed only in use, so nothing said rows were below. It now stays shown at rest in the card's margin, in the quiet text color (3:1 or more on every Omarchy theme). In the preview window the sheet takes the keyboard too, so its keys scroll it, not the preview behind it.
• Menus stop 8 px short of the window edge, and an open submenu's parent keeps a neutral wash instead of the hover accent.

Drops

• Ctrl copies. A drop on the same drive always moved. Holding Ctrl at the drop now copies, and a drop that copies tells the source app so.
• The drop target says what will happen, on a folder, a tile's name, empty space or a column: "Move here" or "Copy here", from Ctrl and whether every file comes from another drive (a drop that mixes drives says "Move here", because the files on this drive are moved), and it follows Ctrl pressed or let go with the pointer still. Files already in the target are left out of that choice, as the drop leaves them.

Screenshots

Before on the left, after on the right, osaka-jade at 1100x700, on the current main.

In the window the selected Exports name is bright, and the details date reads 11:22 AM.

A selected row in the list.

After Alt+click on the only selected tile, the cursor keeps a thin frame.

Moving down past the bottom of the grid, the view follows the cursor.

A right click in the left pane gives it the keys; the right pane goes neutral.

Searching "harbour" gives results named by file, folder beside it, the first neutral while typing.

The same search in the list.

Two photos selected.

A text preview wraps between words.

"Nothing selected" lines up with "This folder is empty".

"6:13 PM" in the details pane.

A restore names the folder it put the file back in.

Delete for good in the Trash: the whole window dims.

The name clash dialog dims the whole window too.

The shortcut sheet at 1100x700 shows its scroll bar at rest, so the rows below are in reach.

A menu pushed up from low in the grid stops 8 px short of the edge.

With Open With open, its parent row keeps a neutral wash.

Not pictured are the drop verbs and Ctrl copy (a held drag cannot be shot) and the keyboard returning after a dialog.

[greptile-apps]

Confidence Score: 5/5

[Medium impact] The PR appears safe to merge; no new actionable issues were found.

Summary

This PR improves file selection, search labels, details, dialogs, and drop hints.

• File views show which item is selected and where the keys are.
• Search results lead with each file's name and show its folder nearby.
• The details pane summarizes a group instead of showing one file as its stand-in.
• Dialogs cover the window, and menus and the shortcut sheet stay clear and usable.
• File drops show whether they will move or copy, and Ctrl makes them copy.

The previous plugin-icon finding is fixed. No new actionable issues were found. The added tests were reviewed but not run.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Files hover a folder] --> B[Cache whether all files come from other drives]
    B --> C[Check Ctrl while hovering]
    C --> D[Show Copy here or Move here]
    D --> E[Files dropped]
    E --> F[Skip files already in the target]
    F --> G{Ctrl held?}
    G -->|Yes| H[Copy all remaining files]
    G -->|No| I[Move on the same drive; copy from other drives]

Loading

_{Reviews (14) · Last reviewed commit: "Drop the selection's accent while the ke..." · Reviewed by Greptile}

[hegjon]

A note on "The cursor stays in sight": the cursorMoved() change fixes more than the grid. On main (and the 0.1.1 package Omarchy installs) the list and the column view have the same bug, which is easier to hit there:

mkdir /tmp/5000; cd /tmp/5000; touch file-{0001..5000}.txt
folio /tmp/5000        # Ctrl+2 for the list
# hold Down for a few seconds

The cursor runs off the bottom and the list never scrolls. Here is folio 0.1.1 after Down was held for 3 s: the list still shows file-0001 to file-0024, while the details pane names file-0113.

I applied the same two lines to main (a2bc0ca) and built it. After 100 Downs the cursor stays on screen in all three views: the list ends on file-101 (a 300-file folder), the grid scrolls row by row to the cursor, and the column view's file column scrolls like the list. Screenshot of the list (Qt 6.12.0, under Hyprland 0.57):

Why it happens: all three views set highlightFollowsCurrentItem: false and have no highlight, so Qt's key navigation changes currentIndex and nothing scrolls. Before this change, only the Shift+arrow and click paths called positionViewAtIndex.

A headless QML test that shows it without folio (fails for views set up like folio's, passes with the change)

QT_QPA_PLATFORM=offscreen /usr/lib/qt6/bin/qmltestrunner -input tst_follow_cursor.qml

import QtQuick
import QtTest

Item {
    id: root
    width: 800
    height: 600

    component FolioList: ListView {
        width: root.width
        height: root.height
        model: 5000
        keyNavigationEnabled: true
        currentIndex: -1
        acceptedButtons: Qt.NoButton
        boundsBehavior: Flickable.StopAtBounds
        highlightFollowsCurrentItem: false
        clip: true
        delegate: Rectangle { width: ListView.view.width; height: 32; color: ListView.isCurrentItem ? "steelblue" : "white" }
    }
    component FolioGrid: GridView {
        width: root.width
        height: root.height
        model: 5000
        cellWidth: 160
        cellHeight: 160
        keyNavigationEnabled: true
        currentIndex: -1
        acceptedButtons: Qt.NoButton
        boundsBehavior: Flickable.StopAtBounds
        highlightFollowsCurrentItem: false
        clip: true
        delegate: Rectangle { width: 150; height: 150; color: GridView.isCurrentItem ? "steelblue" : "white" }
    }

    FolioList { id: folioList; visible: false }
    FolioList {
        id: fixedList
        visible: false
        onCurrentIndexChanged: if (currentIndex >= 0) positionViewAtIndex(currentIndex, ListView.Contain)
    }
    FolioGrid { id: folioGrid; visible: false }
    FolioGrid {
        id: fixedGrid
        visible: false
        onCurrentIndexChanged: if (currentIndex >= 0) positionViewAtIndex(currentIndex, GridView.Contain)
    }

    TestCase {
        name: "FollowCursor"
        when: windowShown

        function test_downKeepsCursorInView_data() {
            return [
                { tag: "folio list", view: folioList },
                { tag: "fixed list", view: fixedList },
                { tag: "folio grid", view: folioGrid },
                { tag: "fixed grid", view: fixedGrid },
            ]
        }

        function test_downKeepsCursorInView(data) {
            const view = data.view
            view.visible = true
            view.forceActiveFocus()
            for (let i = 0; i < 100; ++i)
                keyClick(Qt.Key_Down)
            const item = view.currentItem
            const top = item.y - view.contentY
            const bottom = top + item.height
            const msg = data.tag + ": current index " + view.currentIndex + " at y " + item.y + ", contentY " +
                view.contentY + ", viewport height " + view.height
            view.visible = false
            verify(view.currentIndex > 0, msg)
            verify(top >= 0 && bottom <= view.height, "cursor outside the viewport: " + msg)
        }
    }
}

On Qt 6.12.0:

FAIL!  : ...test_downKeepsCursorInView(folio list) 'cursor outside the viewport: folio list: current index 99 at y 3168, contentY 0, viewport height 600'
PASS   : ...test_downKeepsCursorInView(fixed list)
FAIL!  : ...test_downKeepsCursorInView(folio grid) 'cursor outside the viewport: folio grid: current index 499 at y 15840, contentY 0, viewport height 600'
PASS   : ...test_downKeepsCursorInView(fixed grid)

I tested only Down held, not Up or how the change behaves when the folder is re-read.

[hegjon]

Tested this PR's head (ceb887d) on a Dell XPS 13 (Omarchy, Qt 6.12.0): it fixes the bug in my comment above. With Down held in a folder of 5000 files, the list now scrolls with the cursor, and with Up held it comes back to the top. After 100 Downs the cursor is in view in the list, the grid and the column view.

[thisisgm]

Thanks @hegjon! The same change covers the list and the column view, as your test shows, and the description now says so.