Skip to content

Honor explicit regional date and time locales - #90

Open
aholbreich wants to merge 1 commit into
omacom:mainfrom
aholbreich:fix-regional-time-locale
Open

aholbreich wants to merge 1 commit into
omacom:mainfrom
aholbreich:fix-regional-time-locale

Conversation

@aholbreich

Copy link
Copy Markdown

Fixes #72. Thanks @jotapesse for the English-UI/Portuguese-date report.

Give dates and times a separate locale in list/columns, grid and modified/deleted details:

  • Nonempty LC_ALL takes precedence over LC_TIME.
  • Without an override, keep the UI-language formats and live switching.
  • Explicit C/POSIX locales use Qt's C formats. Unrecognized values fall back to the UI language; invalid nonempty LC_ALL does not try LC_TIME.
  • Preserve locale scripts, translations, numeric formatting, sorting and RTL behavior.

This proposes an explicit regional override to #31's language-coupled date policy; prior maintainer agreement is not assumed. Environment changes require restart.

Testing on Qt 6.12 / CMake 3.31.6:

  • bin/build, bin/test and CTest pass on base and fixed copies in a no-network Bubblewrap sandbox: 192 existing checks plus 13 new locale cases on the fixed tree.
  • Original Date/Time Format Doesn't Follow Regional Date/Time Locale Settings #72 and script-loss negative controls fail as expected. Exact field assertions cover all date views and live language switching.
  • Passing full-suite profile uses en_US.UTF-8 without the optional KDE RAW decoder. Existing C-collation/CR2 expectations also fail on unchanged base; no tests were edited or skipped.

Native visual acceptance is still pending. Nothing has been installed on the live desktop.

AI-assisted implementation and tests.

@greptile-apps

greptile-apps Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no blocking issues were found.

Summary

Dates and times now honor explicit regional settings without changing the UI language.

  • File dates and times can follow a separate regional locale.

No actionable issues were found. This review checked the source; it did not run the tests or perform native visual acceptance.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    UI[UI language] --> Default[Default locale]
    Default --> Numbers[Numbers, sorting and window direction]
    All[Nonempty LC_ALL] --> Dates[Select date locale]
    Time[LC_TIME when LC_ALL is empty] --> Dates
    Default --> Fallback[Fallback when no recognized override exists]
    Fallback --> Dates
    Dates --> Property[translator.dateLocale]
    Property --> Views[List, grid and details dates]
Loading

Reviews (2) · Last reviewed commit: "Honor explicit regional date and time lo..." · Reviewed by Greptile

@aholbreich
aholbreich force-pushed the fix-regional-time-locale branch from d788b17 to a0caf9b Compare November 12, 2026 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Date/Time Format Doesn't Follow Regional Date/Time Locale Settings

1 participant