Repository navigation
Honor explicit regional date and time locales - #90
Open
aholbreich wants to merge 1 commit into
Open
aholbreich wants to merge 1 commit into
aholbreich wants to merge 1 commit into
Conversation
[Medium impact] The PR appears safe to merge; no blocking issues were found. SummaryDates and times now honor explicit regional settings without changing the UI language.
No actionable issues were found. This review checked the source; it did not run the tests or perform native visual acceptance.
|
aholbreich
force-pushed
the
fix-regional-time-locale
branch
from
November 12, 2026 23:55
d788b17 to
a0caf9b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #72. Thanks @jotapesse for the English-UI/Portuguese-date report.
Give dates and times a separate locale in list/columns, grid and modified/deleted details:
LC_ALLtakes precedence overLC_TIME.LC_ALLdoes not tryLC_TIME.This proposes an explicit regional override to #31's language-coupled date policy; prior maintainer agreement is not assumed. Environment changes require restart.
Testing on Qt 6.12 / CMake 3.31.6:
bin/build,bin/testand CTest pass on base and fixed copies in a no-network Bubblewrap sandbox: 192 existing checks plus 13 new locale cases on the fixed tree.en_US.UTF-8without the optional KDE RAW decoder. Existing C-collation/CR2 expectations also fail on unchanged base; no tests were edited or skipped.Native visual acceptance is still pending. Nothing has been installed on the live desktop.
AI-assisted implementation and tests.