Skip to content

soc: apple: retain the live J613 MTP through s2idle - #343

Closed
satchlj wants to merge 4 commits into
omacom:integration/aurorafrom
satchlj:pr/j613-mtp-s2idle
Closed

satchlj wants to merge 4 commits into
omacom:integration/aurorafrom
satchlj:pr/j613-mtp-s2idle

Conversation

@satchlj

@satchlj satchlj commented Nov 3, 2026

Copy link
Copy Markdown

The live J613 MTP adoption path cannot restart its inherited firmware/DMA session and rejects runtime suspend. Add separate system-sleep callbacks that retain the session through s2idle, mark represented supplier paths awake, and check ASC RUN and DART bypass before and after sleep. Reject deeper sleep and refuse destructive recovery after state loss. Ordinary runtime PM and other machines retain their existing policy.

Depends on #328, whose original commits remain in the branch. The exact head builds Image, modules and DTBs successfully. Actual-body fixtures cover normal and aborted cycles, non-J613 peers, deeper-sleep refusal and state loss without reset or INIT. The companion display branch passed the 57-case Linux classic harness. Owner C13h source testing passed docked/undocked s2idle and built-in input recovery; the rearranged head still needs an owner-attended hardware retest.

Keep the boot loader DMA context for a running J613 MTP session. Admit
only the T8122 MTP DART at 0x2fa808000, exactly stream 1, and verify
that its control register still selects bypass before skipping reset.

Select an identity domain and reject paging, blocked-domain attachment
and runtime suspend while the inherited session runs. Retain the clock
and bypass state at removal. This permits the existing mtp-live-v1 RTKit
adoption path to keep serving input without another INIT.

The C-diag11 implementation passed owner input testing on J613 with
firmware 26.6.2. The rebased series requires a separate owner boot test.

Signed-off-by: Satya Benson <satya@benson.earth>
The J613 and J615 25G83 device trees list the MTP as "apple,t8122-mtp",
"apple,t8122-rtk-helper-asc4", "apple,mtp" without the generic
"apple,rtk-helper-asc4" fallback, and say that Linux binds the
SoC-specific compatible. The helper only matches the generic one, so on
those boards it never probes, DockChannel HID defers forever and the
built-in keyboard and trackpad stay absent.

Match "apple,t8122-rtk-helper-asc4" as well.

Signed-off-by: Satya Benson <satya@benson.earth>
Keep the adopted MTP firmware session and identity DMA stream powered through s2idle. Check ASC RUN and bypass before and after sleep, reject deeper sleep, and refuse to reset inherited DMA on loss. Leave non-J613 helpers and ordinary DART runtime PM unchanged.

Exercise the real PM callbacks with host fixtures, including abort unwinding and non-J613 peers. Keep successful retention messages at debug level.

Signed-off-by: Satya Benson <satya@benson.earth>
@satchlj

satchlj commented Nov 11, 2026

Copy link
Copy Markdown
Author

Claude Fable 5.2 on @satchlj's behalf

Closing in favour of aurora-silicon/linux#972, where this change is now maintained against aurora-silicon/linux integration/aurora (still open there).

@satchlj satchlj closed this Nov 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant