Repository navigation
Conversation
NV12 setup ignored every setfile error except EINTR, including a bad header, a short file and a rejected firmware upload. This made an unusable tuning file look like a stream running with model tuning. Keep absent tuning optional, but fail setup for other read, validation and upload errors. Log failed uploads and add a debug message for a successful upload. Exercise failure propagation and missing-file fallback at the capture setup boundary with KUnit static stubs. Distinguish model-wide sensor setfiles from per-module iCCl factory data in Kconfig and document the existing NR commands, P010 omissions and the unimplemented factory calibration/ANE interfaces. Do not change the qualified preview sequence or guess undocumented firmware parameters. (cherry picked from commit 64357f8) Port to integration/aurora: retain its capture sequence; adapt the two setfile KUnit cases to the existing IPC transport. Omit newer H17 preview tests and documentation that do not describe this base. Signed-off-by: Ryan Murray <ryan@aurorasilicon.org> Signed-off-by: Satya Benson <satya@benson.earth>
satchlj
requested review from
chriskearney,
maralcbr and
scottjones
as code owners
November 4, 2026 01:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port Ryan Murray's merged Aurora change #668
(64357f8873ad).
The current capture path ignores most sensor-tuning failures. Keep a missing
setfile optional, but fail setup on read/validation/upload errors, log failed
uploads, and report successful uploads through dynamic debug.
This is independent of #344 and retains integration's capture sequence.
Adapt the two upstream failure/fallback KUnit cases to the existing IPC
transport; omit unrelated newer H17 tests and document only this base.
Model tuning is distinct from per-module factory calibration and ANE denoise.
Authorship and cherry-pick provenance are retained.
Validation: arm64 module compile/MODPOST/link with Clang 18 and
W=1,KUnit object compilation, and 44 source-extracted host setup/fallback cases pass
under ASan/UBSan. Kernel KUnit runtime is not run (module-only build scope). Also all five #344 host suites and both
preview host checks pass with this port applied (using a no-op KUnit hook shim
for the host extractor). No hardware/quality claim;
J613 26.6.2 still needs owner-approved kit testing.