GitAttributes template: add *.groupproj (plus .sql/.ps1/.md) - #3
Open
omonien wants to merge 1 commit into
Open
Conversation
… 2.1 *.groupproj was not declared, so Delphi project groups were exempt from EOL normalization: their line endings depended on each developer's local core.autocrlf setting. A .groupproj belongs to the same toolchain as .dproj and should be treated the same way. Also added .sql, .ps1 and .md -- all common in Delphi repositories (migration scripts, build scripts, documentation) and all previously unspecified. Found while auditing a Delphi project against these standards: the project's .groupproj files reported "text: unspecified" from git check-attr, while every .dproj was correctly normalized. Note for existing repositories: run "git add --renormalize ." after updating, as the header already states. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Delphi Git attributes template changes from version 2.0 to 2.1 and adds CRLF normalization rules for project groups, SQL, PowerShell, and Markdown files. ChangesGit attributes normalization
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
*.groupprojis not declared in the GitAttributes template, so Delphi projectgroups are exempt from EOL normalization — their line endings depend on each
developer's local
core.autocrlfsetting rather than on the repository's rules.A
.groupprojbelongs to the same toolchain as.dproj(the IDE reads and rewritesboth), so it should be normalized the same way.
Found while auditing a Delphi project against these standards:
Change
*.groupproj text eol=crlf— the actual fix.*.sql,*.ps1,*.md— also common in Delphi repositories (migration scripts,build scripts, documentation) and likewise unspecified until now.
2.0→2.1, which brings the template in line withDelphi Style Guide EN.md(already at 2.1) as its own header asks for("keep in sync with Style Guide headers").
Delphi GitIgnore.txtis untouchedand still reads 2.0 — worth a separate look, but out of scope here.
Comments are in English, matching the rest of the template.
Notes
Purely additive — no existing rule is changed or removed. For existing repositories
the header's advice applies unchanged: run
git add --renormalize .after updating.Verified on a real project: after adding the line,
check-attrreportstext: set eol=crlffor the group files,--renormalizereports no content change(the blobs were already normalized), and both project groups still build green.
🤖 Generated with Claude Code
Summary by CodeRabbit