feat: Add version code and version name as a config - #18
Open
farhaanbukhsh wants to merge 1 commit into
Open
farhaanbukhsh wants to merge 1 commit into
farhaanbukhsh wants to merge 1 commit into
Conversation
Signed-off-by: Farhaan Bukhsh <farhaan@opencraft.com>
kaustavb12
reviewed
Sep 24, 2026
| def appVersionCode = config.getOrDefault("VERSION_CODE", 1)?.toString() | ||
| def appVersionName = config.getOrDefault("VERSION_NAME", "1.0.0") | ||
|
|
||
| if (!(appVersionCode ==~ /[0-9]+/) || !appVersionCode.isInteger() || |
Member
There was a problem hiding this comment.
@farhaanbukhsh Since we are already verifying that it's an integer and that it is within the range. Do we still need to do the regex check here ?
Member
|
@farhaanbukhsh I see no difference between the upstream PR and this one. Why do we need to have a 2 branches? I ask because, I made a comment on the upstream PR (similar to @kaustavb12's one here, which I only noticed now. Sorry for the duplication). If you were to make a change based on it, you will have to do it twice now. If both PRs were from the same branch, the update would apply to both PRs. And also be easy to track code-drift in the future with the commit ID. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Information at: openedx#507
Testing instructions
Check upstream
Deadline
"None" if there's no rush, or provide a specific date or event (and reason) if there is one.
Other information
You can use our internal build archive to download the apk file and analyze
Private Ref: https://tasks.opencraft.com/browse/BB-10453