Repository navigation
Action Return TypeDicts - #240
Open
JVickery-TBS wants to merge 5 commits into
Open
JVickery-TBS wants to merge 5 commits into
JVickery-TBS wants to merge 5 commits into
Conversation
Canada release v.2026.10.16
- Added type classes.
- Added change log file.
Member
|
I would put these in |
- Added change log file.
- Added change log file.
Author
|
@wardi stuff is moved now to |
wardi
reviewed
Nov 6, 2026
| value: Required[Any] | ||
| state: str | ||
| deleted: bool | ||
| revision_timestamp: DateTime |
Member
There was a problem hiding this comment.
note: extras dicts have gone away upstream
wardi
reviewed
Nov 6, 2026
Comment on lines
+297
to
+299
| class ResourceShowDict(TypedDict, total=False): | ||
| ''' | ||
| Dictionary returned from the resource_show action. |
Member
There was a problem hiding this comment.
Suggested change
| class ResourceShowDict(TypedDict, total=False): | |
| ''' | |
| Dictionary returned from the resource_show action. | |
| class ResourceDict(TypedDict, total=False): | |
| ''' | |
| Dictionary returned from the resource_show and passed to resource_create/resource_update actions |
wardi
reviewed
Nov 6, 2026
| tracking_summary: TrackingSummaryDict | ||
|
|
||
|
|
||
| class PackageShowDict(TypedDict, total=False): |
Member
There was a problem hiding this comment.
Suggested change
| class PackageShowDict(TypedDict, total=False): | |
| class PackageDict(TypedDict, total=False): |
wardi
reviewed
Nov 6, 2026
| capacity: str | ||
|
|
||
|
|
||
| class OrganizationShowDict(TypedDict, total=False): |
Member
There was a problem hiding this comment.
Suggested change
| class OrganizationShowDict(TypedDict, total=False): | |
| class OrganizationDict(TypedDict, total=False): |
Member
|
otherwise LGTM |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
idk if this is right or not? I tried to just go off of the default schemas