Skip to content

ci: Update the Lost Pixel baseline for data-models 3.0.11, and fix the baseline update job - #88

Open
howaskew wants to merge 2 commits into
masterfrom
ci/lost-pixel-baseline-ref
Open

howaskew wants to merge 2 commits into
masterfrom
ci/lost-pixel-baseline-ref

Conversation

@howaskew

Copy link
Copy Markdown
Contributor

Summary

Updates the Lost Pixel baseline for the scheduledsession page, and fixes the job that creates baseline update pull requests.

Why the baseline needs updating: the scheduledsession page validates scheduledsession-split_example_1.json from openactive.io. data-models 3.0.11 (openactive/data-models#212) fixed that example ("@type" instead of "type"), so the validator no longer shows the deprecated type warning there. Lost Pixel reports a 0.37% difference (3,372 pixels) on that page, which stopped the 3.0.11 deploy and fails the test-validator-site check in data-models, data-model-validator and rpde-validator. The other three pages are unchanged.

How: this pull request's test-site run will fail on that page, and the create-pr-to-update-lost-pixel-baseline job will open a "Lost Pixel update" pull request into this branch with the new screenshot. Review the screenshot (it should only lose the type warning), merge it into this branch, then this pull request's checks should pass. Merging this to master deploys the site with data-models 3.0.11.

Change to test-and-deploy.yml

The baseline update job:

  • checks out github.head_ref || github.ref_name (the pull request's branch, or the branch the workflow was run on) instead of github.event.pull_request.head.ref, which is empty when the workflow is run by hand;
  • names its branch and pull request after the same value, instead of github.ref_name, which for a pull request is <number>/merge.

actionlint: no issues.

When squash-merging, check the suggested commit message does not contain a skip-CI marker.

The baseline update job checked out github.event.pull_request.head.ref,
which is empty when the workflow is run by hand, and named its branch
and pull request after github.ref_name, which for a pull request is
"<number>/merge". Use the pull request's branch name (github.head_ref),
or the branch the workflow was run on.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@openactive-bot
openactive-bot temporarily deployed to openactive-validator-pr-88 October 22, 2026 18:51 Inactive
@howaskew
howaskew requested a review from hkir-dev October 22, 2026 18:53

This branch was successfully deployed

1 active deployment
openactive-validator-pr-88 — 296c904a Deployed Oct 23, 2026 by howaskew
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants