Repository navigation
Conversation
The baseline update job checked out github.event.pull_request.head.ref, which is empty when the workflow is run by hand, and named its branch and pull request after github.ref_name, which for a pull request is "<number>/merge". Use the pull request's branch name (github.head_ref), or the branch the workflow was run on. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the Lost Pixel baseline for the
scheduledsessionpage, and fixes the job that creates baseline update pull requests.Why the baseline needs updating: the
scheduledsessionpage validatesscheduledsession-split_example_1.jsonfrom openactive.io. data-models 3.0.11 (openactive/data-models#212) fixed that example ("@type"instead of"type"), so the validator no longer shows the deprecatedtypewarning there. Lost Pixel reports a 0.37% difference (3,372 pixels) on that page, which stopped the 3.0.11 deploy and fails thetest-validator-sitecheck in data-models, data-model-validator and rpde-validator. The other three pages are unchanged.How: this pull request's
test-siterun will fail on that page, and thecreate-pr-to-update-lost-pixel-baselinejob will open a "Lost Pixel update" pull request into this branch with the new screenshot. Review the screenshot (it should only lose thetypewarning), merge it into this branch, then this pull request's checks should pass. Merging this tomasterdeploys the site with data-models 3.0.11.Change to
test-and-deploy.ymlThe baseline update job:
github.head_ref || github.ref_name(the pull request's branch, or the branch the workflow was run on) instead ofgithub.event.pull_request.head.ref, which is empty when the workflow is run by hand;github.ref_name, which for a pull request is<number>/merge.actionlint: no issues.When squash-merging, check the suggested commit message does not contain a skip-CI marker.