fix: persist Codex review threads - #557
Conversation
|
Thanks, this matches what I asked for in #529. Two things before merge:
|
Thanks — I verified this using real Codex CLI 0.144.4 runs on this branch. Native
So thread persistence is working for both review paths, while local token Would you prefer this PR to remain scoped to thread persistence, with native |
|
Keep it scoped to persistence, this delivers what #529 asked of the plugin. The missing |
Thanks for confirming and for the review. I'll keep the PR scoped to thread persistence. |
…penai#375/openai#557 port) runAppServerInvestigation gains resumeThreadId / persistThread / threadName / buildInvestigatePrompt. Resume failure falls back to a fresh thread (it fails before any turn opens, so no tokens are wasted). Without the new options the thread-start params are byte-identical to before: ephemeral true, unnamed. The queue-driven fake now records thread-lifecycle RPCs in state.requests so tests can assert on thread start/resume/name shape, not just turn payloads. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Summary
Persist Codex threads created by both review commands so their session IDs
remain resumable after the broker restarts.
Fixes #529
Changes
/codex:reviewthreads non-ephemeral/codex:adversarial-reviewephemeral: falseTesting