Repository navigation
Conversation
|
@codex review |
Castiron custom codeEvaluated main: Trusted main policy: ✅ No new custom-code files detected. 0 mixed files remain; 0 existing customizations changed. Compared A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 39348534727 --repo openai/openai-cli \
--name castiron-custom-code-39348534727-1 --dir /tmp/castiron-custom-code-39348534727-1
git apply --stat /tmp/castiron-custom-code-39348534727-1/custom-code.patch
cat /tmp/castiron-custom-code-39348534727-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin 6ec670807e4d9b81d5c58690901c80e121822806 cc902da508ba18d18478b8e08bd0aa67368e74de
python3 scripts/castiron/custom_code_report.py report \
--base 6ec670807e4d9b81d5c58690901c80e121822806 \
--head cc902da508ba18d18478b8e08bd0aa67368e74de --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-cc902da508ba
cat /tmp/castiron-custom-code-cc902da508ba/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ae7fe7fa13
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
@codex review |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
…end-405-current-main-20261016
# Conflicts: # pkg/custom/local_errors.go # pkg/custom/readable_errors.go
…x/spend-405-current-main-20261016
…x/spend-405-current-main-20261016
…end-405-current-main-20261016
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e3968446be
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…end-405-current-main-20261016
Organization owners previously managed spend limits, alerts, and project rates through separate commands.
The Limits workspace combines these controls with exact-dollar review before each change.
This update retains drafts through help, keeps errors visible, and adds the documented fine-tuning model-limits read.
What changes
Alerts remain notifications. Missing enforcement stays unknown. Preflight checks are not atomic, and today's Costs remain partial.
Commands
The workspace routes and fine-tuning read are new. Existing scriptable administration commands remain available.
Administration uses
OPENAI_ADMIN_KEYor--admin-api-key. Forms accept decimal dollars; existing commands retain integer-cent inputs.Fine-tuning model limits uses
OPENAI_API_KEYor explicit Authorization.OPENAI_ADMIN_KEYdoes not supply this command's credentials.It reads one documented endpoint, adds no pagination, and retains SDK read retries.
Root request context and output options remain available.
Pipes, CI, quiet mode, explicit formats, and extraction select the read-only Limits overview.
Workspace lists default to 100 records.
--max-items -1fetches all;0validates requests without retaining records.F1 opens help. Escape restores the draft. Resizing requires rereading the review before Apply becomes available.
Wrapped previews support inspection. Ctrl+P prints complete command bytes after terminal restoration, then exits without applying the draft.
Private overrides and unsupported launch contexts omit printing.
Workspace mutations never retry automatically. Printed commands retain SDK retries and omit workspace preflight checks.
Code
pkg/customowns handwritten commands, API orchestration, workspace behavior, exact arithmetic, and recovery.internal/output/transformowns projections. Existing request, output, and terminal helpers retain their responsibilities.The fine-tuning read uses the SDK request path without inventing a schema.
Synthetic recorder fixtures remain under
scripts/demos. This update adds no packages or dependencies and leaves generated sources andmain.gounchanged.Full website parity needs public contracts for soft budgets, independent enforcement, tiers, upgrades, credits, and approved usage-limit controls.
Organization rate catalogs, percentage alerts, delivery history, and trigger status also remain unsupported by inspected contracts.
Use Platform Limits for available website controls.
Deleting a hard limit does not preserve a soft budget.
Tested
Candidate:
cc902da508ba18d18478b8e08bd0aa67368e74de. Base:e539d9772a0db679dc2c5c1f77fec4df556c9980.Focused checks passed: 22 test parents, 224 test/subtest events, two packages, and zero failures or skips.
The native macOS arm64 build passed.
Bash and Zsh executed eight copied help examples and 32 printed-command cases.
Independent adversarial review accepted the source, runtime results, and terminal captures.
CI at
cc902da5: 41 checks passed and four skipped. Both Castiron status contexts passed. Automated code and security reviews completed with no unresolved findings.Both eleven-scene recordings passed at 80x24 color and 40x12 monochrome.
Independent reviewers inspected all 160 screenshots and 104 samples across 24 animations.
Checks verified mutation counts, exact command printing, error recovery, expected exits, terminal restoration, and cleanup.
SDK CODEOWNER approval remains pending.
Three historical filesystem preflight cases skipped at
555fbc74; invalid-byte filename coverage remains unverified locally.Checks use synthetic fixtures. Live API acceptance, billing changes, and account-specific entitlements remain untested.
Interactive
scripts/run, PowerShell, fish, graphical terminals, and Windows/Linux terminal interactions remain unverified.Demo
Before shows the standalone command at
e6893982. After and the GIF showcc902da5.Both use a synthetic USD 100.00 monthly hard limit. The workspace also shows synthetic alerts, rates, and Costs.
Recordings use Bash on macOS arm64, Menlo 18px, and synthetic loopback fixtures.
Before, historical
e6893982:After,
cc902da5:Recording recipe, scenes, and workspace guide.