Repository navigation
build: bump jvm in / - #1140
build: bump jvm in /#1140dependabot[bot] wants to merge 1 commit into
Conversation
dependabot
Bot
added
dependencies
dependabot
Bot
added
dependencies
Castiron custom codeEvaluated main: ✅ No new custom-code files detected. 113 mixed files remain; 0 existing customizations changed. Compared 113 existing customizations unchanged
73 more in the full report. A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 38795556853 --repo openai/openai-java \
--name castiron-custom-code-38795556853-1 --dir /tmp/castiron-custom-code-38795556853-1
git apply --stat /tmp/castiron-custom-code-38795556853-1/custom-code.patch
cat /tmp/castiron-custom-code-38795556853-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin 0b3dcaaad10b6d303956e989f6a980de2bead5af a76728b1a59a312774b630306a69d136e951542e
python3 scripts/castiron/custom_code_report.py report \
--base 0b3dcaaad10b6d303956e989f6a980de2bead5af \
--head a76728b1a59a312774b630306a69d136e951542e --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-a76728b1a59a
cat /tmp/castiron-custom-code-a76728b1a59a/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1b187c784b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| plugins { | ||
| `kotlin-dsl` | ||
| kotlin("jvm") version "2.2.21" | ||
| kotlin("jvm") version "2.4.20" |
There was a problem hiding this comment.
Updating only the plugin-DSL version leaves implementation("org.jetbrains.kotlin:kotlin-gradle-plugin:2.2.21") in the buildSrc runtime classpath. The repository's security model identifies that plugin version as affected and explicitly requires upgrading both buildSrc Kotlin plugin declarations to a stable 2.4.20-or-later release (docs/architecture/security-model.md:119-126), so this change does not complete the intended remediation.
AGENTS.md reference: AGENTS.md:L34-L36
Useful? React with 👍 / 👎.
| plugins { | ||
| `kotlin-dsl` | ||
| kotlin("jvm") version "2.2.21" | ||
| kotlin("jvm") version "2.4.20" |
There was a problem hiding this comment.
With Kotlin 2.4.20, every SDK module applying openai.kotlin will fail to compile because that convention sets languageVersion to KOTLIN_1_8 (buildSrc/src/main/kotlin/openai.kotlin.gradle.kts:35), and Kotlin 2.3+ rejects -language-version=1.8 as an error. Either retain a Kotlin Gradle plugin that supports the repository's current language contract or migrate that contract in a coordinated compatibility change. Kotlin compatibility guide
AGENTS.md reference: AGENTS.md:L34-L36
Useful? React with 👍 / 👎.
1b187c7 to
f82f4ea
Compare
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Bumps [jvm](https://github.com/JetBrains/kotlin) in `/` from 2.2.21 to 2.4.20. Updates `jvm` from 2.2.21 to 2.4.20 - [Release notes](https://github.com/JetBrains/kotlin/releases) - [Changelog](https://github.com/JetBrains/kotlin/blob/master/ChangeLog.md) - [Commits](JetBrains/kotlin@v2.2.21...v2.4.20) --- updated-dependencies: - dependency-name: jvm dependency-version: 2.4.20 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: sdk-dependencies/jvm ... Signed-off-by: dependabot[bot] <support@github.com>
f82f4ea to
a76728b
Compare
Bumps jvm in
/from 2.2.21 to 2.4.20.Updates
jvmfrom 2.2.21 to 2.4.20Release notes
Sourced from jvm's releases.
... (truncated)
Changelog
Sourced from jvm's changelog.
... (truncated)
Commits
890ac1dAdd Changelog for 2.4.20-RC38860aed🍒 [FIR] Fix suspend conversion when expected type is nullable (#7769)ab5bcd9Edit ChangeLog for 2.4.20-RC29464edcAdd ChangeLog for 2.4.20-RC20261e43Cherry-pick "FixasBodyAndResultVarcall in `visitInlinedLambdaInComposable...0763513[box-tests] Workaround for klib compatibility tests (#7626)045aec6[Wasm] Append scripts from webpack.config.d in the end of the file (#7615)cd7173b🍒 [2.4.20] [K/JS] Keep associated obj annotation only if getInstance survives...d36a2ffCastsOptimizationPass: break aliases cycles (#7578)8664983[CLI] Restore custom IC search scope creation