Skip to content

build: allow temporary accessor compatibility customization - #1191

Closed
jbeckwith-oai wants to merge 1 commit into
mainfrom
codex/java-key-scope-compat-budget-public
Closed

jbeckwith-oai wants to merge 1 commit into
mainfrom
codex/java-key-scope-compat-budget-public

Conversation

@jbeckwith-oai

Copy link
Copy Markdown
Contributor

Raise the custom-code allowance from 3,000 to 3,050 lines to accommodate a temporary Java accessor compatibility customization. It preserves existing primitive accessor signatures while adding optional accessors for requests that can omit those fields.

This PR changes only .castiron-ratchet.json; it does not change SDK APIs or generated code. The compatibility candidate measures 3,009 custom lines, leaving 41 lines under the proposed ceiling. The allowance can be reassessed with the next major-version compatibility changes.

Validation: the trusted checker from public main passes budget isolation and measures this budget-only candidate at 2,986 lines under the existing 3,000-line policy. The increase requires a human approving review.

@jbeckwith-oai
jbeckwith-oai requested a review from a team as a code owner October 16, 2026 01:37
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-16T01:39:19.418044Z 016a656 PR opened
🔒 Security Review ✅ Completed 2026-10-16T01:40:45.589004Z 016a656 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@openai-sdks

openai-sdks Bot commented Oct 16, 2026

Copy link
Copy Markdown
Contributor

OkTest Summary

🟡 Running for Java SDK PR #1191.

View OkTest run #38836118827

SDK merge (pending) · head (016a6564b59e) · base (c36bc50f4cb8) · OkTest (63b471b22245)

@github-actions

Copy link
Copy Markdown
Contributor

Castiron custom code

Evaluated main: c36bc50f4cb86bbf1fcbdc6a7f85f1a451319f1e.

✅ No new custom-code files detected.

113 mixed files remain; 0 existing customizations changed.

Compared c36bc50f4cb8 → 016a6564b59e. Generated baselines verified.

113 existing customizations unchanged
  • openai-java-core/src/main/kotlin/com/openai/models/audio/AudioResponseFormat.kt
  • openai-java-core/src/main/kotlin/com/openai/models/beta/agents/environments/EnvironmentCreateParams.kt
  • openai-java-core/src/main/kotlin/com/openai/models/beta/agents/vaults/credentials/CredentialAuth.kt
  • openai-java-core/src/main/kotlin/com/openai/models/beta/agents/vaults/credentials/CredentialAuthCreateParam.kt
  • openai-java-core/src/main/kotlin/com/openai/models/beta/agents/vaults/credentials/CredentialAuthRotateParam.kt
  • openai-java-core/src/main/kotlin/com/openai/models/beta/responses/BetaResponse.kt
  • openai-java-core/src/main/kotlin/com/openai/models/beta/responses/BetaResponseError.kt
  • openai-java-core/src/main/kotlin/com/openai/models/beta/responses/BetaResponseInjectEvent.kt
  • openai-java-core/src/main/kotlin/com/openai/models/beta/responses/BetaResponseInjectFailedEvent.kt
  • openai-java-core/src/main/kotlin/com/openai/models/beta/responses/BetaResponseStreamEvent.kt
  • openai-java-core/src/main/kotlin/com/openai/models/beta/responses/BetaResponseToolSearchOutputItemParam.kt
  • openai-java-core/src/main/kotlin/com/openai/models/beta/responses/BetaResponsesServerEvent.kt
  • openai-java-core/src/main/kotlin/com/openai/models/chat/completions/ChatCompletionCreateParams.kt
  • openai-java-core/src/main/kotlin/com/openai/models/chat/completions/ChatCompletionMessageFunctionToolCall.kt
  • openai-java-core/src/main/kotlin/com/openai/models/chat/completions/ChatCompletionToolMessageParam.kt
  • openai-java-core/src/main/kotlin/com/openai/models/conversations/ConversationCreateParams.kt
  • openai-java-core/src/main/kotlin/com/openai/models/conversations/items/ItemCreateParams.kt
  • openai-java-core/src/main/kotlin/com/openai/models/embeddings/Embedding.kt
  • openai-java-core/src/main/kotlin/com/openai/models/embeddings/EmbeddingCreateParams.kt
  • openai-java-core/src/main/kotlin/com/openai/models/live/ResponseItemCreateEvent.kt
  • openai-java-core/src/main/kotlin/com/openai/models/realtime/RealtimeResponseStatus.kt
  • openai-java-core/src/main/kotlin/com/openai/models/responses/Response.kt
  • openai-java-core/src/main/kotlin/com/openai/models/responses/ResponseCreateParams.kt
  • openai-java-core/src/main/kotlin/com/openai/models/responses/ResponseError.kt
  • openai-java-core/src/main/kotlin/com/openai/models/responses/ResponseFunctionToolCall.kt
  • openai-java-core/src/main/kotlin/com/openai/models/responses/ResponseFunctionWebSearch.kt
  • openai-java-core/src/main/kotlin/com/openai/models/responses/ResponseInputItem.kt
  • openai-java-core/src/main/kotlin/com/openai/models/responses/ResponseStreamEvent.kt
  • openai-java-core/src/main/kotlin/com/openai/models/responses/ResponseTextConfig.kt
  • openai-java-core/src/main/kotlin/com/openai/models/responses/ResponseToolSearchOutputItemParam.kt
  • openai-java-core/src/main/kotlin/com/openai/models/responses/ResponsesServerEvent.kt
  • openai-java-core/src/main/kotlin/com/openai/models/videos/Video.kt
  • openai-java-core/src/main/kotlin/com/openai/models/videos/VideoCreateError.kt
  • openai-java-core/src/main/kotlin/com/openai/models/webhooks/UnwrapWebhookEvent.kt
  • openai-java-core/src/main/kotlin/com/openai/models/webhooks/WebhookEndpointWithSecret.kt
  • openai-java-core/src/main/kotlin/com/openai/services/async/BetaServiceAsync.kt
  • openai-java-core/src/main/kotlin/com/openai/services/async/BetaServiceAsyncImpl.kt
  • openai-java-core/src/main/kotlin/com/openai/services/async/ImageServiceAsyncImpl.kt
  • openai-java-core/src/main/kotlin/com/openai/services/async/ResponseServiceAsync.kt
  • openai-java-core/src/main/kotlin/com/openai/services/async/ResponseServiceAsyncImpl.kt

73 more in the full report.

A changed generated baseline means this report cannot reliably identify which handwritten lines changed.

Inspect the custom-code diff

Download the exact patch produced by this run (requires repository access):

gh run download 38836148571 --repo openai/openai-java \
  --name castiron-custom-code-38836148571-1 --dir /tmp/castiron-custom-code-38836148571-1
git apply --stat /tmp/castiron-custom-code-38836148571-1/custom-code.patch
cat /tmp/castiron-custom-code-38836148571-1/custom-code.patch

Or reproduce it from an SDK checkout containing the vendored reporter:

git fetch --no-tags origin c36bc50f4cb86bbf1fcbdc6a7f85f1a451319f1e 016a6564b59e01a2787548a6320670f4e5e10d54
python3 scripts/castiron/custom_code_report.py report \
  --base c36bc50f4cb86bbf1fcbdc6a7f85f1a451319f1e \
  --head 016a6564b59e01a2787548a6320670f4e5e10d54 --fetch --require-head-hash --public \
  --out /tmp/castiron-custom-code-016a6564b59e
cat /tmp/castiron-custom-code-016a6564b59e/custom-code.patch

This is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR.

Full report and patch

@dpiet-oai dpiet-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 016a6564b59e01a2787548a6320670f4e5e10d54. No actionable findings. The isolated budget-only change and its stated rationale match the repository policy, and all exact-head hosted jobs completed successfully. I cannot approve because this repository's AGENTS.md expressly prohibits agents from approving budget increases. A human approving review remains required before merge.

Static review only: I did not run tests locally or independently reproduce the reported 3,009-line dependent-candidate measurement.

@jbeckwith-oai
jbeckwith-oai requested a review from a team October 16, 2026 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants