Repository navigation
build: allow temporary accessor compatibility customization - #1191
jbeckwith-oai wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
OkTest Summary🟡 Running for Java SDK PR #1191. SDK merge (pending) · head ( |
Castiron custom codeEvaluated main: ✅ No new custom-code files detected. 113 mixed files remain; 0 existing customizations changed. Compared 113 existing customizations unchanged
73 more in the full report. A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 38836148571 --repo openai/openai-java \
--name castiron-custom-code-38836148571-1 --dir /tmp/castiron-custom-code-38836148571-1
git apply --stat /tmp/castiron-custom-code-38836148571-1/custom-code.patch
cat /tmp/castiron-custom-code-38836148571-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin c36bc50f4cb86bbf1fcbdc6a7f85f1a451319f1e 016a6564b59e01a2787548a6320670f4e5e10d54
python3 scripts/castiron/custom_code_report.py report \
--base c36bc50f4cb86bbf1fcbdc6a7f85f1a451319f1e \
--head 016a6564b59e01a2787548a6320670f4e5e10d54 --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-016a6564b59e
cat /tmp/castiron-custom-code-016a6564b59e/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
dpiet-oai
left a comment
There was a problem hiding this comment.
Reviewed 016a6564b59e01a2787548a6320670f4e5e10d54. No actionable findings. The isolated budget-only change and its stated rationale match the repository policy, and all exact-head hosted jobs completed successfully. I cannot approve because this repository's AGENTS.md expressly prohibits agents from approving budget increases. A human approving review remains required before merge.
Static review only: I did not run tests locally or independently reproduce the reported 3,009-line dependent-candidate measurement.
Raise the custom-code allowance from 3,000 to 3,050 lines to accommodate a temporary Java accessor compatibility customization. It preserves existing primitive accessor signatures while adding optional accessors for requests that can omit those fields.
This PR changes only
.castiron-ratchet.json; it does not change SDK APIs or generated code. The compatibility candidate measures 3,009 custom lines, leaving 41 lines under the proposed ceiling. The allowance can be reassessed with the next major-version compatibility changes.Validation: the trusted checker from public
mainpasses budget isolation and measures this budget-only candidate at 2,986 lines under the existing 3,000-line policy. The increase requires a human approving review.