Repository navigation
test: restore streaming coverage and remove obsolete disables - #1197
Closed
jbeckwith-oai wants to merge 1 commit into
Closed
jbeckwith-oai wants to merge 1 commit into
jbeckwith-oai wants to merge 1 commit into
Conversation
Castiron-Internal-PR: openai/openai-java-internal#286 Castiron-Source-SHA: 79d4fdb282c05ce76488dd30614a8ad7615566b2 Castiron-Public-Base-SHA: 848ef53
jbeckwith-oai
marked this pull request as ready for review
October 16, 2026 15:38
Contributor
Castiron custom codeEvaluated main: Trusted main policy: ✅ No new custom-code files detected. 80 mixed files remain; 4 existing customizations changed; 16 customizations removed. Compared
76 existing customizations unchanged
36 more in the full report. A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 38925751840 --repo openai/openai-java \
--name castiron-custom-code-38925751840-1 --dir /tmp/castiron-custom-code-38925751840-1
git apply --stat /tmp/castiron-custom-code-38925751840-1/custom-code.patch
cat /tmp/castiron-custom-code-38925751840-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin 848ef53c94498e795587d571900202ea383601d4 42083d2360b222b94c60e647299f735e91e0e5f4
python3 scripts/castiron/custom_code_report.py report \
--base 848ef53c94498e795587d571900202ea383601d4 \
--head 42083d2360b222b94c60e647299f735e91e0e5f4 --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-42083d2360b2
cat /tmp/castiron-custom-code-42083d2360b2/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
Contributor
OkTest Summary🟡 Running for Java SDK PR #1197. SDK merge (pending) · head ( |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
jbeckwith-oai
marked this pull request as draft
October 16, 2026 15:43
Contributor
Author
|
Closing this scope expansion. The Java-only handwritten test extraction is already merged in #1190. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restore Java streaming service coverage by removing 20 obsolete Prism-related test disables. Generated streaming tests validate every received event and require at least one event, so an empty stream can no longer pass silently. Existing agent delta assertions remain intact.
Add SSE response declarations for Completions, Responses retrieval, and Assistants run operations. SDK runtime code, JSON response contracts, and compact schemas remain unchanged.
Validation
Formatting and 95 shared tooling regressions passed. The restored service suite passed before the baseline refresh; current-head public CI reruns the Java tests and compatibility checks before merge.