Skip to content

chore(api): use neutral moderation examples - #1222

Merged
jbeckwith-oai merged 1 commit into
mainfrom
castiron/promotions/pr-304
Oct 18, 2026
Merged

jbeckwith-oai merged 1 commit into
mainfrom
castiron/promotions/pr-304

Conversation

@jbeckwith-oai

Copy link
Copy Markdown
Contributor

Summary

Use a generic placeholder for text in moderation examples.

Changes

  • Replace the explicit text example with a neutral placeholder.
  • Keep moderation parameters, response types, and behavior unchanged.

The moderation request uses a neutral placeholder. Its obsolete response example is removed because it described the previous input; response examples are optional. API parameters, response types, and endpoint behavior are unchanged. Both Java moderation examples also use the neutral placeholder.

Castiron-Internal-PR: openai/openai-java-internal#304
Castiron-Source-SHA: 2ee505f1e132ece0965649049289f67ae4f9f30d
Castiron-Public-Base-SHA: 5d6fc3c
@jbeckwith-oai
jbeckwith-oai marked this pull request as ready for review October 18, 2026 04:28
@jbeckwith-oai
jbeckwith-oai requested a review from a team as a code owner October 18, 2026 04:28
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-18T04:30:08.064418Z 6278d68 Draft marked ready
🔒 Security Review ✅ Completed 2026-10-18T04:30:55.213948Z 6278d68 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@openai-sdks

openai-sdks Bot commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

OkTest Summary

✅ 236/236 SDK tests passed in 15.422s for Java SDK PR #1222.

Test results — 42 files
Test Result Time
tests/chat-completions-complex-body.test.ts ✅ Passed 584ms
tests/chat-completions-create.test.ts ✅ Passed 491ms
tests/chat-completions-stream.test.ts ✅ Passed 637ms
tests/files-content-binary.test.ts ✅ Passed 249ms
tests/files-create-multipart.test.ts ✅ Passed 291ms
tests/files-list-pagination.test.ts ✅ Passed 230ms
tests/initialize-config.test.ts ✅ Passed 188ms
tests/instance-isolation.test.ts ✅ Passed 195ms
tests/models-list.test.ts ✅ Passed 367ms
tests/responses-background-lifecycle.test.ts ✅ Passed 299ms
tests/responses-body-method-errors.test.ts ✅ Passed 523ms
tests/responses-cancel-timeout.test.ts ✅ Passed 263ms
tests/responses-cancel.test.ts ✅ Passed 242ms
tests/responses-compact-retries.test.ts ✅ Passed 587ms
tests/responses-compact.test.ts ✅ Passed 241ms
tests/responses-create-advanced-stream.test.ts ✅ Passed 314ms
tests/responses-create-advanced.test.ts ✅ Passed 1.319s
tests/responses-create-disconnect.test.ts ✅ Passed 1.135s
tests/responses-create-errors.test.ts ✅ Passed 289ms
tests/responses-create-malformed-api-responses.test.ts ✅ Passed 377ms
tests/responses-create-retries.test.ts ✅ Passed 255ms
tests/responses-create-stream-failures.test.ts ✅ Passed 1.794s
tests/responses-create-stream-timeout.test.ts ✅ Passed 213ms
tests/responses-create-stream-wire.test.ts ✅ Passed 5.06s
tests/responses-create-stream.test.ts ✅ Passed 180ms
tests/responses-create-terminal-states.test.ts ✅ Passed 611ms
tests/responses-create-timeout.test.ts ✅ Passed 239ms
tests/responses-create.test.ts ✅ Passed 284ms
tests/responses-delete.test.ts ✅ Passed 264ms
tests/responses-input-items-errors.test.ts ✅ Passed 277ms
tests/responses-input-items-list.test.ts ✅ Passed 368ms
tests/responses-input-items-options.test.ts ✅ Passed 190ms
tests/responses-input-tokens-count-timeout.test.ts ✅ Passed 292ms
tests/responses-input-tokens-count.test.ts ✅ Passed 496ms
tests/responses-malformed-inputs.test.ts ✅ Passed 3.956s
tests/responses-not-found-errors.test.ts ✅ Passed 520ms
tests/responses-parse.test.ts ✅ Passed 588ms
tests/responses-retrieve-retries.test.ts ✅ Passed 274ms
tests/responses-retrieve.test.ts ✅ Passed 251ms
tests/responses-stored-method-errors.test.ts ✅ Passed 994ms
tests/retry-behavior.test.ts ✅ Passed 3.376s
tests/sdk-error-shape.test.ts ✅ Passed 438ms

View OkTest run #39097226567

SDK merge (bd2671d30f63) · head (6278d680bb00) · base (5d6fc3c5a58b) · OkTest (ebbcfaca8a5e)

@github-actions

github-actions Bot commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

Castiron custom code

Evaluated main: 5d6fc3c5a58bf7ce1988f06ad3db770c61f469f8.

Trusted main policy: 5d6fc3c5a58bf7ce1988f06ad3db770c61f469f8.

✅ No new custom-code files detected.

98 mixed files remain; 0 existing customizations changed.

Compared 5d6fc3c5a58b → 6278d680bb00. Generated baselines verified.

98 existing customizations unchanged
  • openai-java-core/src/main/kotlin/com/openai/client/OpenAIClientAsyncImpl.kt
  • openai-java-core/src/main/kotlin/com/openai/client/OpenAIClientImpl.kt
  • openai-java-core/src/main/kotlin/com/openai/models/admin/organization/projects/apikeys/ApiKeyUpdateParams.kt
  • openai-java-core/src/main/kotlin/com/openai/models/audio/AudioResponseFormat.kt
  • openai-java-core/src/main/kotlin/com/openai/models/beta/agents/environments/EnvironmentCreateParams.kt
  • openai-java-core/src/main/kotlin/com/openai/models/beta/agents/vaults/credentials/CredentialAuth.kt
  • openai-java-core/src/main/kotlin/com/openai/models/beta/agents/vaults/credentials/CredentialAuthCreateParam.kt
  • openai-java-core/src/main/kotlin/com/openai/models/beta/agents/vaults/credentials/CredentialAuthRotateParam.kt
  • openai-java-core/src/main/kotlin/com/openai/models/beta/responses/BetaResponse.kt
  • openai-java-core/src/main/kotlin/com/openai/models/beta/responses/BetaResponseError.kt
  • openai-java-core/src/main/kotlin/com/openai/models/beta/responses/BetaResponseInjectEvent.kt
  • openai-java-core/src/main/kotlin/com/openai/models/beta/responses/BetaResponseInjectFailedEvent.kt
  • openai-java-core/src/main/kotlin/com/openai/models/beta/responses/BetaResponseStreamEvent.kt
  • openai-java-core/src/main/kotlin/com/openai/models/beta/responses/BetaResponseToolSearchOutputItemParam.kt
  • openai-java-core/src/main/kotlin/com/openai/models/beta/responses/BetaResponsesServerEvent.kt
  • openai-java-core/src/main/kotlin/com/openai/models/chat/completions/ChatCompletionCreateParams.kt
  • openai-java-core/src/main/kotlin/com/openai/models/chat/completions/ChatCompletionMessageFunctionToolCall.kt
  • openai-java-core/src/main/kotlin/com/openai/models/chat/completions/ChatCompletionToolMessageParam.kt
  • openai-java-core/src/main/kotlin/com/openai/models/conversations/ConversationCreateParams.kt
  • openai-java-core/src/main/kotlin/com/openai/models/conversations/items/ItemCreateParams.kt
  • openai-java-core/src/main/kotlin/com/openai/models/embeddings/Embedding.kt
  • openai-java-core/src/main/kotlin/com/openai/models/embeddings/EmbeddingCreateParams.kt
  • openai-java-core/src/main/kotlin/com/openai/models/live/ResponseItemCreateEvent.kt
  • openai-java-core/src/main/kotlin/com/openai/models/realtime/RealtimeResponseStatus.kt
  • openai-java-core/src/main/kotlin/com/openai/models/responses/Response.kt
  • openai-java-core/src/main/kotlin/com/openai/models/responses/ResponseCreateParams.kt
  • openai-java-core/src/main/kotlin/com/openai/models/responses/ResponseError.kt
  • openai-java-core/src/main/kotlin/com/openai/models/responses/ResponseFunctionToolCall.kt
  • openai-java-core/src/main/kotlin/com/openai/models/responses/ResponseFunctionWebSearch.kt
  • openai-java-core/src/main/kotlin/com/openai/models/responses/ResponseInputItem.kt
  • openai-java-core/src/main/kotlin/com/openai/models/responses/ResponseStreamEvent.kt
  • openai-java-core/src/main/kotlin/com/openai/models/responses/ResponseTextConfig.kt
  • openai-java-core/src/main/kotlin/com/openai/models/responses/ResponseToolSearchOutputItemParam.kt
  • openai-java-core/src/main/kotlin/com/openai/models/responses/ResponsesServerEvent.kt
  • openai-java-core/src/main/kotlin/com/openai/models/videos/Video.kt
  • openai-java-core/src/main/kotlin/com/openai/models/videos/VideoCreateError.kt
  • openai-java-core/src/main/kotlin/com/openai/models/webhooks/UnwrapWebhookEvent.kt
  • openai-java-core/src/main/kotlin/com/openai/models/webhooks/WebhookEndpointWithSecret.kt
  • openai-java-core/src/main/kotlin/com/openai/services/async/BetaServiceAsync.kt
  • openai-java-core/src/main/kotlin/com/openai/services/async/BetaServiceAsyncImpl.kt

58 more in the full report.

A changed generated baseline means this report cannot reliably identify which handwritten lines changed.

Inspect the custom-code diff

Download the exact patch produced by this run (requires repository access):

gh run download 39097265956 --repo openai/openai-java \
  --name castiron-custom-code-39097265956-1 --dir /tmp/castiron-custom-code-39097265956-1
git apply --stat /tmp/castiron-custom-code-39097265956-1/custom-code.patch
cat /tmp/castiron-custom-code-39097265956-1/custom-code.patch

Or reproduce it from an SDK checkout containing the vendored reporter:

git fetch --no-tags origin 5d6fc3c5a58bf7ce1988f06ad3db770c61f469f8 6278d680bb00531c7daa0167c3c3bc7de89a974f
python3 scripts/castiron/custom_code_report.py report \
  --base 5d6fc3c5a58bf7ce1988f06ad3db770c61f469f8 \
  --head 6278d680bb00531c7daa0167c3c3bc7de89a974f --fetch --require-head-hash --public \
  --out /tmp/castiron-custom-code-6278d680bb00
cat /tmp/castiron-custom-code-6278d680bb00/custom-code.patch

This is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR.

Full report and patch

@markstuart-oai markstuart-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6278d680bb00531c7daa0167c3c3bc7de89a974f. The neutral moderation examples and removal of the obsolete response example are consistent. The generated parameter, multimodal, serialization, and service tests retain their assertions. Both handwritten Java examples use the same neutral input. API types and runtime code remain unchanged. No correctness or maintainability findings.

Validation: reviewed the complete pinned diff and surrounding code, checked the transformed-spec structure, and verified the generated-file hashes. Hosted lint, build logic, build, version-support, and Java 8/25 runtime checks pass. At the last check, SDK tests, ProGuard/R8 tests, Jackson/API compatibility, and external OkTest were still running. I did not execute candidate code or tests locally.

@jbeckwith-oai
jbeckwith-oai added this pull request to the merge queue Oct 18, 2026
Merged via the queue into main with commit 1a2fe5c Oct 18, 2026
19 checks passed
@openai-sdks openai-sdks Bot mentioned this pull request Oct 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants