Repository navigation
chore(api): use neutral moderation examples - #1222
Conversation
Castiron-Internal-PR: openai/openai-java-internal#304 Castiron-Source-SHA: 2ee505f1e132ece0965649049289f67ae4f9f30d Castiron-Public-Base-SHA: 5d6fc3c
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Castiron custom codeEvaluated main: Trusted main policy: ✅ No new custom-code files detected. 98 mixed files remain; 0 existing customizations changed. Compared 98 existing customizations unchanged
58 more in the full report. A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 39097265956 --repo openai/openai-java \
--name castiron-custom-code-39097265956-1 --dir /tmp/castiron-custom-code-39097265956-1
git apply --stat /tmp/castiron-custom-code-39097265956-1/custom-code.patch
cat /tmp/castiron-custom-code-39097265956-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin 5d6fc3c5a58bf7ce1988f06ad3db770c61f469f8 6278d680bb00531c7daa0167c3c3bc7de89a974f
python3 scripts/castiron/custom_code_report.py report \
--base 5d6fc3c5a58bf7ce1988f06ad3db770c61f469f8 \
--head 6278d680bb00531c7daa0167c3c3bc7de89a974f --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-6278d680bb00
cat /tmp/castiron-custom-code-6278d680bb00/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
markstuart-oai
left a comment
There was a problem hiding this comment.
Reviewed 6278d680bb00531c7daa0167c3c3bc7de89a974f. The neutral moderation examples and removal of the obsolete response example are consistent. The generated parameter, multimodal, serialization, and service tests retain their assertions. Both handwritten Java examples use the same neutral input. API types and runtime code remain unchanged. No correctness or maintainability findings.
Validation: reviewed the complete pinned diff and surrounding code, checked the transformed-spec structure, and verified the generated-file hashes. Hosted lint, build logic, build, version-support, and Java 8/25 runtime checks pass. At the last check, SDK tests, ProGuard/R8 tests, Jackson/API compatibility, and external OkTest were still running. I did not execute candidate code or tests locally.
Summary
Use a generic placeholder for text in moderation examples.
Changes
The moderation request uses a neutral placeholder. Its obsolete response example is removed because it described the previous input; response examples are optional. API parameters, response types, and endpoint behavior are unchanged. Both Java moderation examples also use the neutral placeholder.