Repository navigation
build(deps): bump com.fasterxml.jackson.core:jackson-databind in / - #905
Conversation
Bumps [com.fasterxml.jackson.core:jackson-databind](https://github.com/FasterXML/jackson) in `/` from 2.18.9 to 2.22.1. Updates `com.fasterxml.jackson.core:jackson-databind` from 2.18.9 to 2.22.1 - [Commits](https://github.com/FasterXML/jackson/commits) --- updated-dependencies: - dependency-name: com.fasterxml.jackson.core:jackson-databind dependency-version: 2.22.1 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: gradle ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
jbeckwith-oai
left a comment
jbeckwith-oai
left a comment
There was a problem hiding this comment.
Overview
This updates the Dokka-only buildscript constraint from Jackson Databind 2.18.9 to 2.22.1. The surrounding constraint logic derives one version from Databind and applies it to every Jackson build-tool module.
Confirmed Findings
- [High] The derived patch version points
jackson-annotationsat a nonexistent artifact- Location: build.gradle.kts:14, interacting with the module constraints at lines 17-24.
- Why: Jackson 2.20+ intentionally gives annotations a two-part version.
jackson-annotations:2.22exists;jackson-annotations:2.22.1does not. Exact-head CI therefore fails before project configuration completes, and every downstream check is skipped. Failed CI - Suggested fix: Use the Jackson BOM or an explicit version map that resolves annotations to
2.22while allowing the 2.22.1 patch versions for Databind/core/other modules.
Rejected Findings
None.
Residual Risks
None beyond the deterministic dependency-resolution failure. Requesting changes; this PR must not merge in its current form.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Addressed the requested Jackson alignment fix in 73faeef, and merged current main (head 52e2f0a). Both the buildscript constraints and isolated Dokka resolution now use jackson-annotations:2.22 while keeping the other Jackson modules at 2.22.1. Published SDK dependency versions are unchanged. Verified buildscript/Dokka dependency resolution and successful Dokka Javadoc generation; build-logic tests passed (50 passed, 1 skipped) and Kotlin lint passed. Two fresh, independent security-focused review rounds found no in-scope blockers. Remote CI is now running; human re-review is still needed. |
Castiron custom code✅ No new custom-code files detected. 87 mixed files remain; 0 existing customizations changed. Compared 87 existing customizations unchanged
47 more in the full report. A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 35931565620 --repo openai/openai-java \
--name castiron-custom-code-35931565620-1 --dir /tmp/castiron-custom-code-35931565620-1
git apply --stat /tmp/castiron-custom-code-35931565620-1/custom-code.patch
cat /tmp/castiron-custom-code-35931565620-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin 82440c9c05a0e2983c47d55dbcd9f4cf889bd9ec 52e2f0a481093282ea5f971732fea2d36770a202
python3 scripts/castiron/custom_code_report.py report \
--base 82440c9c05a0e2983c47d55dbcd9f4cf889bd9ec \
--head 52e2f0a481093282ea5f971732fea2d36770a202 --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-52e2f0a48109
cat /tmp/castiron-custom-code-52e2f0a48109/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
jbeckwith-oai
left a comment
jbeckwith-oai
left a comment
There was a problem hiding this comment.
Re-reviewed at 52e2f0a. The previous Jackson annotations resolution blocker is fixed: both the buildscript constraint and Dokka-only resolution rule select annotations 2.22, while Databind and the other aligned modules remain on 2.22.1. This matches the upstream Jackson 2.22.1 BOM.
Reviewed the complete diff and the surrounding build/publication configuration. Published SDK Jackson remains 2.18.9; the version catalog, core dependency/compatibility configuration, and publication plugin are unchanged from the base. No remaining blocking findings.
Verified CI run 35931538134 passed on this exact head, including build, lint, tests, Jackson/API compatibility, and Java 8/25 runtime checks. I inspected the build log and performed source/BOM consistency checks; I did not rerun Gradle or Dokka locally.
This approval supersedes my earlier changes-requested review.
markstuart-oai
left a comment
markstuart-oai
left a comment
There was a problem hiding this comment.
Reviewed the complete change at 52e2f0a. Both Dokka resolution paths now align Jackson 2.22.1 with annotations 2.22, while the published SDK dependencies remain unchanged. No actionable correctness or maintainability findings.
Verified 12 successful exact-head hosted checks and both Castiron statuses. Source review only; I did not rerun Gradle or Dokka locally.
Automated Release PR --- ## [4.69.2](openai/openai-java@v4.69.1...v4.69.2) (2026-09-24) ### Bug Fixes * buffer completion text with linear accumulation ([openai#1051](openai#1051)) ([0971c87](openai@0971c87)) ### Build System * **deps:** bump com.fasterxml.jackson.core:jackson-databind in / ([openai#905](openai#905)) ([fc18819](openai@fc18819)) * **deps:** bump gradle/actions/setup-gradle from 5.0.2 to 6.3.0 ([openai#932](openai#932)) ([3f00bce](openai@3f00bce)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: openai-sdks[bot] <284451331+openai-sdks[bot]@users.noreply.github.com>
3 participants
Rebasing might not happen immediately, so don't worry if this takes some time.
Note: if you make any changes to this PR yourself, they will take precedence over the rebase.
Bumps com.fasterxml.jackson.core:jackson-databind in
/from 2.18.9 to 2.22.1.Updates
com.fasterxml.jackson.core:jackson-databindfrom 2.18.9 to 2.22.1Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditions