Repository navigation
build(deps): bump org.jetbrains.kotlin:kotlin-gradle-plugin in / - #909
dependabot[bot] wants to merge 1 commit into
Conversation
Bumps [org.jetbrains.kotlin:kotlin-gradle-plugin](https://github.com/JetBrains/kotlin) in `/` from 1.9.20 to 2.4.10. Updates `org.jetbrains.kotlin:kotlin-gradle-plugin` from 1.9.20 to 2.4.10 - [Release notes](https://github.com/JetBrains/kotlin/releases) - [Changelog](https://github.com/JetBrains/kotlin/blob/master/ChangeLog.md) - [Commits](JetBrains/kotlin@v1.9.20...v2.4.10) --- updated-dependencies: - dependency-name: org.jetbrains.kotlin:kotlin-gradle-plugin dependency-version: 2.4.10 dependency-type: direct:production update-type: version-update:semver-major dependency-group: gradle ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
dependabot
Bot
added
dependencies
OkTest Summary❌ Failed for Java SDK PR #909. SDK merge ( |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1cfb71a58c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
|
||
| dependencies { | ||
| implementation("org.jetbrains.kotlin:kotlin-gradle-plugin:1.9.20") | ||
| implementation("org.jetbrains.kotlin:kotlin-gradle-plugin:2.4.10") |
There was a problem hiding this comment.
Kotlin 2.4.10 no longer supports the Kotlin 1.8 language/API level, but the shared openai.kotlin convention still sets both languageVersion and apiVersion to KOTLIN_1_8 in buildSrc/src/main/kotlin/openai.kotlin.gradle.kts. Consequently, compiling any SDK module that applies this convention fails with an unsupported language-version error; either retain a compatible compiler or update and validate the language/API compatibility settings as part of this upgrade.
Useful? React with 👍 / 👎.
|
|
||
| dependencies { | ||
| implementation("org.jetbrains.kotlin:kotlin-gradle-plugin:1.9.20") | ||
| implementation("org.jetbrains.kotlin:kotlin-gradle-plugin:2.4.10") |
There was a problem hiding this comment.
The buildSrc project still applies kotlin("jvm") version "1.9.20" on line 3, while this dependency puts Kotlin Gradle Plugin 2.4.10 classes on its compilation classpath. The Kotlin 1.9 compiler cannot consume the newer Kotlin metadata used by those classes, including the Gradle DSL types imported by the convention plugins, so buildSrc compilation fails before the SDK modules are configured. Upgrade both declarations together as required by SECURITY.md, or leave both on 1.9.20.
Useful? React with 👍 / 👎.
jbeckwith-oai
left a comment
jbeckwith-oai
left a comment
There was a problem hiding this comment.
Overview
This updates only the buildSrc implementation dependency for the Kotlin Gradle Plugin from 1.9.20 to 2.4.10. It does not update the explicit kotlin("jvm") plugin declaration or the repository Kotlin 1.8 language/API compatibility configuration.
Confirmed Findings
- [High] The partial Kotlin upgrade breaks buildSrc and desynchronizes plugin versions
- Location: buildSrc/build.gradle.kts:13; failure manifests at
buildSrc/src/main/kotlin/openai.kotlin.gradle.kts:35-36. - Why: Kotlin 2.4 reports
KOTLIN_1_8as unsupported, so:buildSrc:compileKotlinfails and all downstream build, test, API, and runtime checks are skipped. The implementation and applied plugin versions would also differ. Failed CI - Suggested fix: Keep 1.9.20, or perform a coordinated migration of the plugin declaration, implementation dependency, language/API version, core-library version, and published Kotlin compatibility policy.
- Location: buildSrc/build.gradle.kts:13; failure manifests at
Rejected Findings
None.
Residual Risks
None beyond the confirmed compile blocker. Requesting changes; this PR must not merge in its current form.
markstuart-oai
added
the
sdk-breaking-change
|
Superseded by #1079, now merged. It upgrades both Kotlin build declarations together to 2.2.21 while preserving the SDK's Kotlin language/API 1.8 settings, stdlib 1.8.0, and Java runtime floors. The standalone 2.4.10 bump here is therefore no longer needed. Closing as superseded. |
|
This pull request was built based on a group rule. Closing it will not ignore any of these versions in future pull requests. To ignore these dependencies, configure ignore rules in dependabot.yml |
) ## Summary Upgrade both Kotlin build declarations together from 1.9.20 to 2.2.21. Supersedes openai#909 and openai#930. Their separate 2.4.10 bumps leave the declarations mismatched and do not support the SDK's pinned Kotlin 1.8 language level. Kotlin 2.2.21 supports the existing Gradle 8.12 and Kotlin 1.8 language/API settings. The diff changes only the two version declarations. Java runtime floors, Kotlin language/API 1.8, stdlib 1.8.0, and Gradle/Dokka/publishing configuration remain unchanged. Expected SDK release treatment: patch within the existing compatibility contract. ## Validation - Build logic tests and full CI build command (Jackson compatibility run separately) - Kotlin and Java lint - Baseline/proposed API compatibility checks against main at 2cbf22c - All four artifact runtime probes on Java 21 - Offline tests with SKIP_MOCK_TESTS=true, including Jackson compatibility and ProGuard/R8 - Generated Maven POMs for all four artifacts still declare kotlin-stdlib-jdk8 1.8.0 - Two consecutive clean adversarial-review rounds, each with two independent reviewers; dependency/security scope reviewed - git diff --check GitHub CI will additionally run mock-server tests and Java 8/25 runtime probes. Gradle emits an embedded-Kotlin version warning and Kotlin 1.8 deprecation warnings; the local validations above pass with those warnings. This is not a claim of security remediation. ## References - https://kotlinlang.org/docs/gradle-configure-project.html - https://kotlinlang.org/docs/compatibility-guide-22.html
3 participants
Rebasing might not happen immediately, so don't worry if this takes some time.
Note: if you make any changes to this PR yourself, they will take precedence over the rebase.
Bumps org.jetbrains.kotlin:kotlin-gradle-plugin in
/from 1.9.20 to 2.4.10.Updates
org.jetbrains.kotlin:kotlin-gradle-pluginfrom 1.9.20 to 2.4.10Release notes
Sourced from org.jetbrains.kotlin:kotlin-gradle-plugin's releases.
... (truncated)
Changelog
Sourced from org.jetbrains.kotlin:kotlin-gradle-plugin's changelog.
... (truncated)
Commits
5687445Add Changelog for 2.4.10-RC2ba30392[Wasm] Support regenerate unchanged modules flag on KGP6307e73[Wasm] Implement Xwasm-IC-generate-unchanged-modules flag39d7aeeAdd ChangeLog for 2.4.10-RC2a2956be[Gradle] Update karma.conf.js to use 'require(...)' instead plain strings9b1361c[Gradle] KT-87223: Updated regression testa4c153a[Gradle] KT-87223: Fix toochain to 2.4.0 for abiValidation compat configbc04b90Add ChangeLog for 2.4.10-RCbbcb94b[CRI] explicitly disable CRI generation for non-JVM targets to avoid false-po...6c2c458Scripting: fix jvmTarget processing from script annotationsYou can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditions