Repository navigation
chore(api): use neutral moderation examples - #2969
Conversation
Castiron-Internal-PR: openai/openai-node-internal#324 Castiron-Source-SHA: 4cc4e2441126957375bbb002ffc64d5b8ac5b42c Castiron-Public-Base-SHA: e989fc0
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Castiron custom codeEvaluated main: Trusted main policy: ✅ No new custom-code files detected. 47 mixed files remain; 0 existing customizations changed. Compared 47 existing customizations unchanged
7 more in the full report. A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 39096733809 --repo openai/openai-node \
--name castiron-custom-code-39096733809-1 --dir /tmp/castiron-custom-code-39096733809-1
git apply --stat /tmp/castiron-custom-code-39096733809-1/custom-code.patch
cat /tmp/castiron-custom-code-39096733809-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin e989fc07033981150d68c4e06e8600452b46494c c6b62dc466661ba90231b4764edf1d6f5942b0a3
python3 scripts/castiron/custom_code_report.py report \
--base e989fc07033981150d68c4e06e8600452b46494c \
--head c6b62dc466661ba90231b4764edf1d6f5942b0a3 --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-c6b62dc46666
cat /tmp/castiron-custom-code-c6b62dc46666/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
markstuart-oai
left a comment
markstuart-oai
left a comment
There was a problem hiding this comment.
Reviewed c6b62dc466661ba90231b4764edf1d6f5942b0a3. The neutral moderation examples and removal of the obsolete response example are consistent. The two generated tests retain their request options and raw/parsed response assertions; only their input strings change. API types and runtime code remain unchanged. No correctness or maintainability findings.
Validation: reviewed the complete pinned diff and surrounding code, checked the transformed-spec structure, and verified generated-file hashes. Hosted Node.js 22/24/26 tests, builds, lint, compatibility checks, and CodeQL pass. I did not run candidate code or tests locally.
Automated Release PR --- ## [7.39.0](openai/openai-node@v7.38.0...v7.39.0) (2026-10-18) ### Features * **realtime:** add opt-in bounded connection recovery ([openai#2968](openai#2968)) ([64872e5](openai@64872e5)) ### Chores * **api:** use neutral moderation examples ([openai#2969](openai#2969)) ([3a3b852](openai@3a3b852)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: openai-sdks[bot] <284451331+openai-sdks[bot]@users.noreply.github.com>
2 participants
Summary
Use a generic placeholder for text in moderation examples.
Changes
The moderation request uses a neutral placeholder. Its obsolete response example is removed because it described the previous input; response examples are optional. API parameters, response types, and endpoint behavior are unchanged.