Repository navigation
fix(ci): expose published install failures - #1008
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: needs maintainer review before merge. What this changesThis PR prints a bounded, path-redacted error summary when the native macOS check fails to install published OpenClaw. Example: The macOS lifecycle check's published OpenClaw installation exits with code 1.
Review scores
ProductKind: Bug fix · Worth it: Yes · Fix scope: Complete Merge readiness✅ Ready for maintainer review Keep open: this maintainer-authored PR makes a useful, narrowly scoped diagnostic improvement absent from current main; no introduced correctness defect was found. Priority: P3 Before mergeNone. FindingsNone. Tests
Agent review detailsHow this fits togetherThe macOS CI lifecycle script invokes the candidate OCM CLI to install published OpenClaw and validate launchd behavior; failed commands produce private logs and selected public diagnostic summaries. flowchart LR
A[macOS CI job] --> B[Lifecycle validation script]
B --> C[OCM published installation]
C --> D[Captured command output]
D --> E[Private complete log]
D --> F[Bounded redacted Actions summary]
Technical reviewBest possible solution: Retain this minimal extension of the existing diagnostic owner without changing installation behavior or weakening the lifecycle gate. Do we have a high-confidence way to reproduce the issue? Current-main source shows that the published-install call uses start rather than service, so its nonzero exit bypasses the public error summary. Is this the best way to solve the issue? The one-condition extension is the smallest complete fix for the stated diagnostic gap and preserves the existing summary and failure-handling implementation. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against f41dc3d316c6. Provenance checked
TestingProof path: none. SecurityNone. EvidenceWhat I checked:
Preflight sourceSource unknown. Source comparison at the observed PR snapshot only. Completion is self-reported; body, policy, tests, execution, and report bytes are not verified. LabelsLabel changes:
Label justifications:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment Reviewed November 5, 2026, 8:54 PM ET / November 6, 2026, 01:54 UTC. |
What Problem This Solves
A failed published OpenClaw installation stops the native macOS lifecycle check without showing the install error in Actions logs.
User Impact
Maintainers can diagnose the failed installation before retrying a release. This changes CI diagnostics only.
Why This Change Was Made
Apply the existing bounded error summary to the published-install step. It replaces the temporary-state and home paths and retains the complete log privately with mode 0600. Service diagnostics and the lifecycle gate are unchanged.
Evidence