Skip to content

fix(ci): expose published install failures - #1008

Merged
vincentkoc merged 1 commit into
mainfrom
fix/ocm-release-install-diagnostic
Nov 6, 2026
Merged

vincentkoc merged 1 commit into
mainfrom
fix/ocm-release-install-diagnostic

Conversation

@vincentkoc

Copy link
Copy Markdown
Member

What Problem This Solves

A failed published OpenClaw installation stops the native macOS lifecycle check without showing the install error in Actions logs.

User Impact

Maintainers can diagnose the failed installation before retrying a release. This changes CI diagnostics only.

Why This Change Was Made

Apply the existing bounded error summary to the published-install step. It replaces the temporary-state and home paths and retains the complete log privately with mode 0600. Service diagnostics and the lifecycle gate are unchanged.

Evidence

  • Reproduced in the native macOS job of release preparation CI: the published-install command returned 1, and the underlying error was retained only on the ephemeral runner.
  • The diff changes one condition. Existing native-Gateway Python checks and the real macOS lifecycle job provide remote validation.
  • This exposes the installation error; it does not claim to fix its cause.

@clawsweeper

clawsweeper Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

ClawSweeper review complete

ClawSweeper finished reviewing this revision. The review result is being finalized.

View the workflow run.

@clawsweeper clawsweeper Bot added clawsweeper:intake:bug Preliminary submission classification; full source review pending. clawsweeper:intake:needs-environment Preliminary submission classification; full source review pending. clawsweeper:intake:needs-repro Preliminary submission classification; full source review pending. P3 Low-risk cleanup, docs, polish, ergonomics, or speculative feature. rating: 🦐 gold shrimp Decent PR readiness signal, but merge confidence is limited. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. and removed clawsweeper:intake:bug Preliminary submission classification; full source review pending. clawsweeper:intake:needs-environment Preliminary submission classification; full source review pending. clawsweeper:intake:needs-repro Preliminary submission classification; full source review pending. labels Nov 6, 2026
@clawsweeper

clawsweeper Bot commented Nov 6, 2026

Copy link
Copy Markdown

Codex review: needs maintainer review before merge.

What this changes

This PR prints a bounded, path-redacted error summary when the native macOS check fails to install published OpenClaw.

Example: The macOS lifecycle check's published OpenClaw installation exits with code 1.

  • Before: Actions shows the exit code and a generic failure while the underlying error remains in a private runner log.
  • After: Actions also shows the final 2,000 characters of the installation error, replacing the test-state and home paths.

Review scores

Measure Result What it means
Overall readiness 🦐 gold shrimp (3/6) The patch is minimal and source-correct, with limited direct evidence for the newly exposed diagnostic path.
Proof confidence 🦐 gold shrimp (3/6) This maintainer-authored PR is outside the ordinary contributor proof gate; the supplied historical failure establishes context, but inspected evidence does not demonstrate the changed failure-output branch.
Patch quality 🐚 platinum hermit (4/6) No actionable review findings were identified.

Product

Kind: Bug fix · Worth it: Yes · Fix scope: Complete
User problem: Maintainers cannot see the installation error when the native macOS lifecycle check fails before service validation.
Reason: The existing area owner authored this narrowly scoped repair, which makes a failed CI step diagnosable at negligible maintenance cost.

Merge readiness

✅ Ready for maintainer review

Keep open: this maintainer-authored PR makes a useful, narrowly scoped diagnostic improvement absent from current main; no introduced correctness defect was found.

Priority: P3
Reviewed head: e267a0c04994c5fd6a653a4446e64df45981dd90

Before merge

None.

Findings

None.

Tests

  • Missing end-to-end proof: No inspected after-change output demonstrates a failed published installation printing the bounded, path-redacted summary.
Agent review details

How this fits together

The macOS CI lifecycle script invokes the candidate OCM CLI to install published OpenClaw and validate launchd behavior; failed commands produce private logs and selected public diagnostic summaries.

flowchart LR
  A[macOS CI job] --> B[Lifecycle validation script]
  B --> C[OCM published installation]
  C --> D[Captured command output]
  D --> E[Private complete log]
  D --> F[Bounded redacted Actions summary]
Loading

Technical review

Best possible solution:

Retain this minimal extension of the existing diagnostic owner without changing installation behavior or weakening the lifecycle gate.

Do we have a high-confidence way to reproduce the issue?

Current-main source shows that the published-install call uses start rather than service, so its nonzero exit bypasses the public error summary.

Is this the best way to solve the issue?

The one-condition extension is the smallest complete fix for the stated diagnostic gap and preserves the existing summary and failure-handling implementation.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning medium; reviewed against f41dc3d316c6.

Provenance checked

Testing

Proof path: none.

Security

None.

Evidence

What I checked:

Preflight source

Source unknown. Source comparison at the observed PR snapshot only. Completion is self-reported; body, policy, tests, execution, and report bytes are not verified.

Labels

Label changes:

  • add P3: This improves maintainer-facing CI diagnostics without changing installed application behavior.
  • add rating: 🦐 gold shrimp: Overall readiness is 🦐 gold shrimp; proof is 🦐 gold shrimp and patch quality is 🐚 platinum hermit.
  • add status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR.

Label justifications:

  • P3: This improves maintainer-facing CI diagnostics without changing installed application behavior.
  • rating: 🦐 gold shrimp: Overall readiness is 🦐 gold shrimp; proof is 🦐 gold shrimp and patch quality is 🐚 platinum hermit.
  • status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR.

Rank-up moves

Optional improvements that raise the rating; they are not merge blockers.

  • Capture a failed published-install run showing the bounded summary and path replacement, with sensitive output redacted.

Rating scale

6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior.

Workflow

ClawSweeper edits this one comment on every review. Comment @clawsweeper re-review for a fresh review only. Repair and merge execution lanes are retired.

Reviewed November 5, 2026, 8:54 PM ET / November 6, 2026, 01:54 UTC.

@vincentkoc
vincentkoc merged commit d24c36b into main Nov 6, 2026
14 checks passed
@vincentkoc
vincentkoc deleted the fix/ocm-release-install-diagnostic branch November 6, 2026 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P3 Low-risk cleanup, docs, polish, ergonomics, or speculative feature. rating: 🦐 gold shrimp Decent PR readiness signal, but merge confidence is limited. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant