fix(proxy): make OCS capabilities endpoint unprotected - #3173
Open
kost wants to merge 1 commit into
Open
Conversation
Anonymous/unauthenticated clients need to read /ocs/v[12].php/cloud/ capabilities before they've ever authenticated -- it's how a client discovers server capabilities, including auth-related ones, in the first place. It fell through to the general /ocs/ policy route, which requires auth, so anonymous requests got a 401 instead of the (public-safe) capabilities payload. Mirrors the existing precedent for /ocs/v[12].php/config a few lines above, which already carries Unprotected: true for the same reason.
Up to standards ✅🟢 Issues
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Anonymous/unauthenticated clients need to read /ocs/v[12].php/cloud/ capabilities before they've ever authenticated - it's how a client discovers server capabilities, including auth-related ones, in the first place. It fell through to the general /ocs/ policy route, which requires auth, so anonymous requests got a 401 instead of the (public-safe) capabilities payload.
Mirrors the existing precedent for /ocs/v[12].php/config a few lines above, which already carries Unprotected: true for the same reason.
Types of changes