chore(deps): hold vitest below 5 until vitest-pool-workers supports it - #102
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. 2 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 4 reviews per hour. Your free on-demand review promotion remains active until October 9, 2026 at 6:00 PM UTC. 📝 WalkthroughWalkthroughThe root npm Dependabot configuration now ignores Vitest versions 5.0.0 and later. A comment explains the Vitest 4 requirement for the Cloudflare pool workers package. ChangesVitest version constraint
Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to The change is intended to keep Dependabot from proposing Vitest 5 while the pool-workers package requires Vitest 4. No concrete merge-blocking failure is established; proceed with normal checks. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
Why
The npm-major group (#101) bumps
vitestfrom 4 to 5. The control-plane integration tests run in workerd through@cloudflare/vitest-pool-workers, and its latest release (0.22.0) declarespeerDependencies: { vitest: "^4.1.0" }. With vitest 5 in the group, the install ends up mixing vitest 4 (pulled in by pool-workers) and vitest 5. That also breaks the web tests' jest-dom matcher types, so the other majors in the group can't be judged on their own.Like the TypeScript 7 hold, this one waits on the ecosystem, not on us.
What
One ignore entry in
.github/dependabot.yml:vitest >= 5.0.0. The comment says to drop it once pool-workers accepts vitest 5. After it merges, Dependabot rebuilds the group without vitest. I'll then fix what the remaining majors need (TypeScript 6 needsrootDirand an explicittypeslist) on that PR.🤖 Generated with Claude Code
Summary by CodeRabbit