ci: regenerate image locks on Dependabot PRs, hold eslint 9 - #83
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (2)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The last round of Dependabot PRs (#75–#82) were all red. This fixes two of the causes.
packages/sandbox-runtime/uv.lockbut cannot runsandbox:images lock, sopackages/sandbox-images/locks/runtime.txtgoes stale and the Sandbox Images freshness check (plustest_deploy.py) fails. Dependabot was also hand-editing the generatedlocks/*.txtfiles as pip requirements, pushing them past whatuv.lockresolves.eslint-plugin-react's peer range, sonpm installfails with ERESOLVE and every TS job goes red.What changed
.github/dependabot.ymluv:exclude-paths: packages/sandbox-images/locks/**so Dependabot stops editing generated lock files.npm: ignoreeslintand@eslint/js>= 10.0.0, same style as the existing better-auth entry..github/workflows/dependabot-image-locks.yml: on Dependabot PRs that touchsandbox-runtime/uv.lock, runssandbox:images lock(uv 0.9.7, same as CI) and pushes the regenerated locks back to the PR branch.Required setup
The push uses a GitHub App token so the new commit re-triggers CI (a
GITHUB_TOKENpush would not). Dependabot-triggered runs only see Dependabot secrets, soGH_APP_IDandGH_APP_PRIVATE_KEYneed to be added under Settings → Secrets → Dependabot. The app needs Contents: write on this repo.Not covered
The npm-major group still contains TypeScript 7, Tailwind 4, Vitest 5 etc., and the npm minor/patch and Litestream 0.5 PRs had their own code-level breakages. Those are separate.
Verification
lock --checkfails before (sameruntime.txt is staleerror as CI) and passes after.test:node-version-workflow-contractandtest:terraform-workflow-contractpass; Prettier clean; YAML parses.🤖 Generated with Claude Code
Summary by CodeRabbit