fix(plugins): show one full-description tooltip in Browse by deniial00 · Pull Request #1035 · opengeos/RustGIS

deniial00 · 2026-10-27T17:26:14Z

Summary

Fix duplicate full-description tooltips when hovering a truncated description in Plugin Manager › Browse.
Root cause: egui's truncated Label automatically shows the full text, while browse_row also adds an explicit tooltip. Disable only the label's automatic elision tooltip; retain the existing tooltip with the complete translated description and any withdrawal reason.
Preserve the readable one-line description, existing hover access, and all other Plugin Manager behavior. Document the hover behavior; no dependencies or redesign.

Testing

Ran the actual changed UI with cargo run --release -p rustgis-ui-egui --example ui_shot -- /tmp/rustgis-plugin-tooltip.jsonl at 1366×900, dark theme.
Opened Browse, filtered to IDE Chile 0.5.0, moved the pointer onto its truncated description, and held it for 12 frames before capture. Inspected the resulting PNG: exactly one tooltip contains the complete registry description, including the final “the IDE Chile catalogue.” sentence; the truncated description remains visible.
cargo xtask ci — passed (format check, workspace/all-targets Clippy with warnings denied, workspace tests, dependency-layer check).
pre-commit run --all-files — passed.
No permanent source-text or widget-wiring test added; the exercised hover screenshot verifies the consumer-visible behavior.

UI evidence

Before — supplied report, two stacked copies of the full description:

After — changed UI, one tooltip with the complete description:

Screenshots are GitHub attachments, not committed assets.

Related issue

None; fixes the screenshot-reported duplicate tooltip.

Summary by CodeRabbit

Bug Fixes
- Browse descriptions stay on one line, with hovering showing the full description. For withdrawn plugins, the tooltip also displays the withdrawal reason.
Documentation
- Updated the Plugin Manager documentation to explain the one-line descriptions and hover tooltip details.

coderabbitai · 2026-10-27T17:26:32Z

No actionable comments were generated in the recent review.

Recent review info

Run configuration

Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: ASSERTIVE
Plan: Advanced
Run ID: faa148dd-7f42-47cb-b4e2-0df9ad82cd98

Commits

Reviewing files that changed from the base of the PR and between 5302ee3 and 5a757f8.

Files selected for processing: 2

crates/ui-egui/src/pluginsui.rs
docs/plugins.md

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 5 remain after this review.

Walkthrough

The Plugin Manager’s Browse description suppresses egui’s automatic elision tooltip. The explicit hover tooltip continues to show the full description and, for withdrawn plugins, the withdrawal reason. Documentation describes this behavior.

Changes: Plugin Browse Tooltip

Layer / File(s)	Summary
Description tooltip behavior `crates/ui-egui/src/pluginsui.rs`, `docs/plugins.md`	The description label suppresses the automatic elision tooltip. The documentation states that descriptions stay on one line and that hovering shows the full description and, for withdrawn plugins, the withdrawal reason.

Priority: Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Bug fix

Suggested reviewers: giswqs

Merge Risk: Minimal · up to 5a757

The tooltip change is ready to merge; no concrete regression was identified.

Pre-merge checks: 5

Check name	Status	Explanation
Title check		The title clearly and concisely identifies the main change: showing one complete description tooltip in the Plugin Manager Browse view.
Description check		The description includes the required Summary, Testing, UI evidence, and Related issue sections. It explains the root cause, implementation, validation steps, screenshots, and issue status.
Docstring Coverage		Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within survi…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 1 functions across 1 files. (1 skipped: 1 unsupported.)

Finishing Touches

🧪 Generate unit tests (beta)

Create a new PR

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{A rabbit hops past Browse today,
The long description stays at bay.
Hover reveals the words in full,
And withdrawal notes when they are there.
The rabbit thumps: “That tooltip’s clear!”}

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-10-27T17:27:12Z

        tip = format!("{tip}\n\n{r}");
    }
-    let desc = ui.add(egui::Label::new(egui::RichText::new(description).size(12.0)).truncate());
+    // The explicit tooltip below includes the withdrawal reason; don't also show egui's elision tooltip.


Nit: this comment repeats the one at lines 790-791 (the tooltip already carries the withdrawal reason). Consider merging them into one comment above the let desc line so the reasoning sits in one place. Not blocking.

github-actions · 2026-10-27T17:27:18Z

Code review

Bugs: None found. show_tooltip_when_elided(false) only turns off egui's automatic elision tooltip. The explicit on_hover_text(tip) still runs and carries the full description plus any withdrawal reason, so a truncated description gets one tooltip. Before this change, the two tooltips stacked, which matches the reported screenshot. Confidence: high.

Security: None. The change touches only UI tooltip wiring and docs.

Performance: None.

Quality:

Nit: the comment at crates/ui-egui/src/pluginsui.rs:797 repeats the one at lines 790–791. Merging them into one comment above the let desc line would keep the reasoning in one place. Posted inline. Confidence: high.

AGENTS.md:

No new user-visible strings, so no tl! or i18n work is needed.
No new assets, dependencies or unwrap/panic paths.
The new line is about 126 characters, inside the repo's max_width = 140 in rustfmt.toml.
The docs addition in docs/plugins.md follows the surrounding bullet indentation.
The PR adds no regression test. That is acceptable here because it is not a crash fix, and the author describes a screenshot check instead. Confidence: medium.

Not verified: I could not read egui 0.37 source from this environment, so the show_tooltip_when_elided method name is unconfirmed. The PR reports cargo xtask ci passing, which compiles it, so I rely on that.

Change size

Compared: the whole PR against main (merge base 5445d00 to PR head 5a757f8).

Measure	Value
Files changed	2 (added 0, modified 2, removed 0, renamed 0)
Size before	79.1 KB
Size after	79.4 KB
Total size change	+282 B

Path	Before	After	Change
`docs/plugins.md`	36.4 KB	36.6 KB	+144 B
`crates/ui-egui/src/pluginsui.rs`	42.7 KB	42.8 KB	+138 B

github-actions · 2026-10-27T17:39:08Z

📖 Docs preview

Item	Value
Preview	https://preview.rustgis.app/pr-1035/
Web app	https://preview.rustgis.app/pr-1035/app/
Commit	`5a757f8`

GitHub Pages takes a minute or two to publish a new commit. Newer commits from the fork aren't published until a maintainer adds the preview label (once per commit).

fix(plugins): show one full-description tooltip in Browse

5a757f8

github-actions Bot reviewed Oct 27, 2026

View reviewed changes

coderabbitai Bot approved these changes Oct 27, 2026

View reviewed changes

deniial00 merged commit 69e9688 into opengeos:main Oct 27, 2026
18 checks passed

Navigation Menu

Repository navigation

fix(plugins): show one full-description tooltip in Browse - #1035

fix(plugins): show one full-description tooltip in Browse#1035
deniial00 merged 1 commit into
opengeos:mainfrom
deniial00:plugin-manager-tooltip-fix

deniial00 commented Oct 27, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Oct 27, 2026 •

edited

Loading

Uh oh!

github-actions Bot Oct 27, 2026

Uh oh!

github-actions Bot commented Oct 27, 2026

Uh oh!

github-actions Bot commented Oct 27, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

deniial00 commented Oct 27, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Testing

UI evidence

Related issue

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Oct 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot Oct 27, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Oct 27, 2026

Code review

Change size

Uh oh!

github-actions Bot commented Oct 27, 2026

📖 Docs preview

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

deniial00 commented Oct 27, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Oct 27, 2026 •

edited

Loading