Skip to content

Potential fix for code scanning alert no. 2: Incorrect conversion between integer types #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MichaelSp merged 1 commit into from
Sep 17, 2026
Merged

Potential fix for code scanning alert no. 2: Incorrect conversion between integer types #284

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions pkg/init/webhooks/flags.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,12 @@ func BindFlags(fs *flag.FlagSet) *Flags {
})

fs.Func("webhooks-service-port", "Port of the webhooks service (not the webhook server itself)", func(s string) error {
port, err := strconv.Atoi(s)
result.InstallOptions = append(result.InstallOptions, WithWebhookServicePort(port))
return err
parsedPort, err := strconv.ParseInt(s, 10, 32)
if err != nil {
return err
}
result.InstallOptions = append(result.InstallOptions, WithWebhookServicePort(int(parsedPort)))
return nil
})

fs.Func("webhooks-additional-sans", "Additional Subject Alternative Names (SANs) that should be added to the self-signed webhook certificate. Multiple domains can be specified as comma-separated values.", func(s string) error {
Expand Down
Loading