build(nix): split development shells - #5028
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe PR replaces the single inline Nix shell with layered Go, API, full, and CI shells. Contributor guidance and CI checks now select the smallest shell that provides their required tools. ChangesNix development shell layers
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to The PR separates development tooling into purpose-specific shells while retaining the complete default and CI environments. No actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
2ed298c to
b8b5853
Compare
b8b5853 to
b52dca3
Compare
Pull request was closed
Summary
.#goshell for root Go code generation without Node.#apishell that layers the pinned Node runtime, pnpm, and API generation tools on the Go shelldefaultand.#cias the complete compatibility environment, while moving generator CI commands and developer guidance to the purpose-specific shellsValidation
nix flake check --impurenix develop --impure .#gosmoke test and fullmake generate.#goclosure contains no Node, pnpm, or V8 derivationsnix develop --impure .#apismoke test: Nodev26.8.1matches.nvmrc; pnpm, yq, Go, and make are availablenix develop --impure .#cicompatibility smoke test for the existing broad toolsetgit diff --checkSummary by CodeRabbit
New Features
Documentation
Chores
Greptile Summary
The PR splits the Nix development environment into purpose-specific Go and API shells while retaining the complete default/CI environment.
goand layeredapidevelopment shells.Confidence Score: 5/5
The PR appears safe to merge.
No blocking failure remains.
Important Files Changed
Reviews (3): Last reviewed commit: "build(nix): split development shells" | Re-trigger Greptile