Make a default overridable adapter in core by conico974 · Pull Request #35 · opennextjs/adapters-api

conico974 · 2026-06-27T19:43:43Z

Make a default overridable adapter in core.
Remove unused files and dependencies related to AWS, improve build processes, and update TypeScript and Node versions.
Enhance the AWS adapter with default overrides and integrate Cloudflare-specific configurations.
Clean up the codebase by removing outdated examples and unnecessary utilities. Fix various build and CI issues.

…y into core adapter feat: enhance build process with additional server bundle customization options chore: update package.json scripts for improved build and testing workflow test: add unit tests for adapter build process and server bundle generation fix: ensure proper handling of external dependencies and edge configuration in server bundle

…ests for resolve plugin

…specific overrides

pkg-pr-new · 2026-06-27T19:44:23Z

Open in StackBlitz

npm i https://pkg.pr.new/@opennextjs/cloudflare@35

commit: d1b99ee

devin-ai-integration

Devin Review found 3 potential issues.

…udflare specific overrides" This reverts commit 37c4d90.

…re configuration

@ts-expect-error

…ad of throwing - Extract ValidateConfigResult type with success/message/shouldThrow/level - Convert validateFunctionOptions and validateSplittedFunctionOptions to return result objects - Remove logger dependency from validateConfig.ts - Preserve compatibilityMatrix, TODO comment, @ts-expect-error pragmas - Add 5 characterization tests in validateConfig.spec.ts - No caller impact: compileConfig.ts is the sole importer (updated in T3)

@ts-expect-error

- Export OpenNextOutput interface (was internal) - Extract buildOpenNextOutput(buildOpts) for construction-only (no fs write) - Keep legacy generateOutput as thin wrapper (construction + file write) - Preserve all construction logic verbatim, including @ts-expect-error - Add 3 characterization tests in generateOutput.spec.ts - Backward compatible: byte-equivalent output to today

- Replace bare validateConfig(config) call with result-handling block - Throw on shouldThrow:true (bad routes — preserves existing behavior) - Log at appropriate level on shouldThrow:false (level field from T1) - All 3 export signatures and edge-runtime detection block unchanged - Direct callers (aws/build.ts, cloudflare/utils.ts) unaffected

…OpenNextAdapterOptions - Make OpenNextAdapterOptions<T = OpenNextOutput> and buildAdapter<T> generic - Add validateConfig override hook (runs after callback in modifyConfig) - Add generateOutput override hook (returns T, gated by skipGenerateOutput) - buildAdapter serializes override return via fs.writeFileSync (override never touches fs) - Default path uses buildOpenNextOutput (extracted in T2) - Add 5 new tests covering override behaviors + default path + skipGenerateOutput - All 16 existing adapter tests preserved; AWS/Cloudflare adapters compile with default T

When an adapter config specifies full package-specifier paths (e.g., @opennextjs/aws/overrides/wrappers/aws-lambda.js), esbuild cannot resolve them during bundling. Use createRequire(args.path).resolve() in the openNextResolvePlugin to convert package specifiers to filesystem-relative paths at build time, falling back to the original value if resolution fails. This fixes the openbuild:local build error: ERROR: Could not resolve "@opennextjs/aws/overrides/wrappers/aws-lambda.js" ERROR: Could not resolve "@opennextjs/aws/overrides/tagCache/dynamodb.js" Added test I verifying resolution of a mock package in node_modules.

james-elicx · 2026-07-17T23:08:13Z

+		skipWarmer: true,
+		skipGenerateOutput: true,
+		middlewareOptions: { forceOnlyBuildOnce: true },
+		beforeMiddleware: async (buildOpts, _config) => {


i think this might make more sense as beforeServerBundle given we have afterServerBundle now, and just consider middleware to be part of the server bundle step.

could potentially even be moved inside serverBundle as pre and post hooks.

james-elicx · 2026-07-17T23:35:16Z

+			fs.copyFileSync(cache.cache, path.join(tempCachePath, "cache.cjs"));
+			fs.copyFileSync(cache.composableCache, path.join(tempCachePath, "composable-cache.cjs"));


couldnt these also be mjs files?

shouldnt the ext be based on the ext of the original filename?

I haven't tested it in a while, but the original reason was that Next didn't work with mjs at the time.

james-elicx · 2026-07-17T23:38:02Z

+		},
+
+		async onBuildComplete(ctx) {
+			console.log("OpenNext build will start now");


is there a reason we're using console.log in here instead of our own logger fns?

Nope, I just forgot about it 😄

james-elicx · 2026-07-17T23:40:30Z

+				const { useTagCache } = createCacheAssets(buildOpts);
+				console.log("Cache assets created");
+				if (useTagCache) {


this is just my react-pilled mind, but i always find it slightly odd seeing useThing naming to start variables instead of shouldUseThing 😅

james-elicx · 2026-07-17T23:48:18Z

 		{
 			entryPoints: [path.join(options.openNextDistDir, "adapters", "server-adapter.js")],
-			external: ["next", "./middleware.mjs", "./next-server.runtime.prod.js"],
+			external: codeCustomization?.externals ?? ["next", "./middleware.mjs", "./next-server.runtime.prod.js"],


do we not want to treat custom externals as additive to the default ones? if not, what would you think of always having an adapter explicitely provide them?

i guess in cloudflare that means we only externalise middleware now instead of all 3. i think it might be clearer what's going on to have external be explicitely passed by each? WDYT?

Yeah, I think that now that the build stuff is common and configurable, it make sense to provide them by each adapter, as this is likely something that people will want to customize

james-elicx · 2026-07-17T23:55:49Z

 * @returns
 */
-export function openNextResolvePlugin({ overrides, fnName }: IPluginSettings): Plugin {
+export function openNextResolvePlugin({


can we look at if we're able to do something with the esbuild onResolve hook instead of the ast etc. stuff we're adding here?

I guess I could give it a try yeah

conico974 added 5 commits June 27, 2026 17:17

feat: implement default overrides for bundle configurations and add t…

8de81a4

…ests for resolve plugin

format

53b4ccb

fix ts issue

e9f8a3c

feat: add default overrides for AWS adapter and integrate Cloudflare …

37c4d90

…specific overrides

devin-ai-integration Bot reviewed Jun 27, 2026

View reviewed changes

Comment thread packages/cloudflare/src/cli/adapter.ts

Comment thread packages/core/src/build/adapter.ts

Comment thread packages/cloudflare/src/api/config.ts Outdated

conico974 added 8 commits June 27, 2026 21:54

Revert "feat: add default overrides for AWS adapter and integrate Clo…

14bf0cd

…udflare specific overrides" This reverts commit 37c4d90.

feat: enhance AWS adapter with default overrides and improve middlewa…

a101e18

…re configuration

format

d1b99ee

james-elicx reviewed Jul 17, 2026

View reviewed changes

		fs.copyFileSync(cache.cache, path.join(tempCachePath, "cache.cjs"));
		fs.copyFileSync(cache.composableCache, path.join(tempCachePath, "composable-cache.cjs"));

Uh oh!

Conversation

conico974 commented Jun 27, 2026 • edited by devin-ai-integration Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new Bot commented Jun 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

conico974 commented Jun 27, 2026 •

edited by devin-ai-integration Bot

Loading

pkg-pr-new Bot commented Jun 27, 2026 •

edited

Loading