Skip to content

chore: replace bingo with Go 1.24 tool directives#293

Open
kuudori wants to merge 1 commit into
openshift-hyperfleet:mainfrom
kuudori:chore/replace-bingo-with-go-tool-directives
Open

chore: replace bingo with Go 1.24 tool directives#293
kuudori wants to merge 1 commit into
openshift-hyperfleet:mainfrom
kuudori:chore/replace-bingo-with-go-tool-directives

Conversation

@kuudori

@kuudori kuudori commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

HYPERFLEET-1330

Remove bingo tool management in favor of native tool directives in go.mod (Go 1.24+).
Tool versions are pinned in go.mod/go.sum and resolved via go tool <name>.

Pinned versions (unchanged from bingo):

  • golangci-lint v2.7.0
  • gotestsum v1.13.0
  • helm-docs v1.14.2
  • kubeconform v0.7.0
  • mockgen v0.6.0
  • oapi-codegen v2.6.0

@openshift-ci

openshift-ci Bot commented Jul 10, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci

openshift-ci Bot commented Jul 10, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kuudori for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Jul 10, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Excluded labels (none allowed) (2)
  • do-not-merge/work-in-progress
  • do-not-merge/hold

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 02de2c19-9000-444e-95b2-398ec30cef32

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
✨ Simplify code
  • Create PR with simplified code

Comment @coderabbitai help to get the list of available commands.

@kuudori kuudori force-pushed the chore/replace-bingo-with-go-tool-directives branch 4 times, most recently from 09b40c5 to 31443df Compare July 10, 2026 19:16
@kuudori kuudori force-pushed the chore/replace-bingo-with-go-tool-directives branch from 31443df to 01614af Compare July 10, 2026 19:32
@kuudori kuudori force-pushed the chore/replace-bingo-with-go-tool-directives branch from 01614af to fcdba71 Compare July 10, 2026 19:33
@kuudori kuudori marked this pull request as ready for review July 10, 2026 19:40
@openshift-ci openshift-ci Bot requested review from pnguyen44 and rh-amarin July 10, 2026 19:40
@hyperfleet-ci-bot

Copy link
Copy Markdown

Risk Score: 4 — risk/high

Signal Detail Points
PR size 2479 lines (>500) +2
Sensitive paths none +0
Test coverage No _test.go files in diff +2

Computed by hyperfleet-risk-scorer

@openshift-ci

openshift-ci Bot commented Jul 10, 2026

Copy link
Copy Markdown

@kuudori: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/presubmits-integration fcdba71 link true /test presubmits-integration
ci/prow/unit fcdba71 link true /test unit
ci/prow/validate-commits fcdba71 link true /test validate-commits
ci/prow/helm-test fcdba71 link true /test helm-test
ci/prow/lint fcdba71 link true /test lint

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant