Enhance loadtesting for Openshift Version Prod Validations

[edisonLcardenas]

Change log:

• Add new regions
• Add options to select a region, select multiple region, select range, and load test in all regions.

[openshift-ci]

Hi @edisonLcardenas. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: edisonLcardenas
Once this PR has been reviewed and has the lgtm label, please assign sudobrendan for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[vinaybommana]

looks good to me,

only things is regions: italynorth and taiwannorth are dropped can you please check again

[edisonLcardenas]

looks good to me,

only things is regions: italynorth and taiwannorth are dropped can you please check again
I aligned the file with here:
https://msazure.visualstudio.com/AzureRedHatOpenShift/_git/ARO-Scripts?path=/powerShellActions/rp-locations-map.json

[tkesharw-RH]

Hey Ed, there were minor checks and changes I found. Please review them.
Thanks,
Tejas

[tkesharw-RH]

This drops the final region westus3 from regions.txt as it lacks a trailing newline.
It will stop at westus2. 47 regions will be loaded instead of 48.
We can have 2 fixes.

1. change the logic to -> while IFS= read -r line || [[ -n "$line" ]]; do
2. Add a trailing newline to regions.txt

[tkesharw-RH]

There is a scope of duplication when selecting regions.
Eg. 1 3 4 4 6 6 7 8
It could target existing tmux sessions and there could be scope of duplication in cluster create/delete operations.

We could add this fix.
duplicates=$(printf '%s\n' "${selected_regions[@]}" | sort | uniq -d)

if [[ -n "$duplicates" ]]; then
echo "Duplicate region selected: $duplicates"
exit 1
fi

[tkesharw-RH]

Suppose one load test is already running in a session named loadtest. Starting the script again makes tmux new-session fail because that name already exists.

Commands tmux new-window and send-keys target existing load test and the second run could inject additional Azure create/delete commands into its panes

Fix:
Add this checks:
if tmux has-session -t "$SESSION" 2>/dev/null; then
echo "tmux session '$SESSION' already exists"
exit 1
fi