Skip to content

[release-4.20] OCPBUGS-99782: Backport node_e2e test migrations - #31430

Open
Chandan9112 wants to merge 1 commit into
openshift:release-4.20from
Chandan9112:backport-node-e2e-4.20
Open

[release-4.20] OCPBUGS-99782: Backport node_e2e test migrations#31430
Chandan9112 wants to merge 1 commit into
openshift:release-4.20from
Chandan9112:backport-node-e2e-4.20

Conversation

@Chandan9112

Copy link
Copy Markdown
Contributor

Summary

Bulk backport of node_e2e test case migrations from main (OCP 5.0) to release-4.20.

These tests were previously backported to release-4.22 via PR #31306 (merged ✅) and to release-4.21 via PR #31426. This PR performs the same backport to release-4.20.

Jira

OCPBUGS-99782

Related PRs

Release PR Status
4.22 #31306 Merged ✅
4.21 #31426 Open

Changes (15 files)

New test files (test/extended/node/node_e2e/)

File Test Feature
container_runtime_config.go ContainerRuntimeConfig pidsLimit/overlaySize CRC CRD (GA)
image_mirror_set.go ImageDigestMirrorSet / ImageTagMirrorSet IDMS/ITMS (GA)
image_registry_config.go Image registry allowedRegistries config image.config (GA)
initcontainer.go Init container restart behavior Core k8s
netns_cleanup.go Network namespace cleanup kubelet/CRI-O
node.go Kubelet log level, cgroupv2, devfuse Core node
pdb_drain.go PDB 100% minAvailable blocks drain PDB (GA)
probe_termination.go Probe terminationGracePeriodSeconds Core k8s

Helper files added

  • node_utils.go — Helper functions (ExecOnNodeWithChroot, WaitForMCP, etc.)
  • node_mcp_helpers.go — Custom MCP creation/cleanup (NodeHasCustomRole)

Modified files

  • imagepolicy.go — Exported GetMCPCurrentSpecConfigName and WaitForMCPConfigSpecChangeAndUpdated for cross-package access
  • README.md — Updated documentation
  • bindata.go — Regenerated to include new testdata

Testdata

  • testdata/node/node_e2e/pod-dev-fuse.yaml — Test fixture for devfuse test

Feature Verification

All backported tests target features available in OCP 4.20:

  • ContainerRuntimeConfig, IDMS/ITMS, image registry config, PDBs, probes are GA
  • Node cgroupv2, devfuse, kubelet logging are core node features
  • All tests use [Suite:openshift/disruptive-longrunning] tag

Made with Cursor

@openshift-ci

openshift-ci Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 27, 2026
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 27, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@Chandan9112: This pull request references Jira Issue OCPBUGS-99782, which is invalid:

  • expected dependent Jira Issue OCPBUGS-99671 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

Bulk backport of node_e2e test case migrations from main (OCP 5.0) to release-4.20.

These tests were previously backported to release-4.22 via PR #31306 (merged ✅) and to release-4.21 via PR #31426. This PR performs the same backport to release-4.20.

Jira

OCPBUGS-99782

Related PRs

Release PR Status
4.22 #31306 Merged ✅
4.21 #31426 Open

Changes (15 files)

New test files (test/extended/node/node_e2e/)

File Test Feature
container_runtime_config.go ContainerRuntimeConfig pidsLimit/overlaySize CRC CRD (GA)
image_mirror_set.go ImageDigestMirrorSet / ImageTagMirrorSet IDMS/ITMS (GA)
image_registry_config.go Image registry allowedRegistries config image.config (GA)
initcontainer.go Init container restart behavior Core k8s
netns_cleanup.go Network namespace cleanup kubelet/CRI-O
node.go Kubelet log level, cgroupv2, devfuse Core node
pdb_drain.go PDB 100% minAvailable blocks drain PDB (GA)
probe_termination.go Probe terminationGracePeriodSeconds Core k8s

Helper files added

  • node_utils.go — Helper functions (ExecOnNodeWithChroot, WaitForMCP, etc.)
  • node_mcp_helpers.go — Custom MCP creation/cleanup (NodeHasCustomRole)

Modified files

  • imagepolicy.go — Exported GetMCPCurrentSpecConfigName and WaitForMCPConfigSpecChangeAndUpdated for cross-package access
  • README.md — Updated documentation
  • bindata.go — Regenerated to include new testdata

Testdata

  • testdata/node/node_e2e/pod-dev-fuse.yaml — Test fixture for devfuse test

Feature Verification

All backported tests target features available in OCP 4.20:

  • ContainerRuntimeConfig, IDMS/ITMS, image registry config, PDBs, probes are GA
  • Node cgroupv2, devfuse, kubelet logging are core node features
  • All tests use [Suite:openshift/disruptive-longrunning] tag

Made with Cursor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 6320917f-4f38-4f86-965d-375984f99d7f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Chandan9112
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Chandan9112
Chandan9112 marked this pull request as ready for review July 27, 2026 05:20
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 27, 2026
@openshift-ci
openshift-ci Bot requested review from deads2k and p0lyn0mial July 27, 2026 05:20
@Chandan9112

Copy link
Copy Markdown
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jul 27, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@Chandan9112: This pull request references Jira Issue OCPBUGS-99782, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.z) matches configured target version for branch (4.20.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-99671 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-99671 targets the "4.21.z" version, which is one of the valid target versions: 4.21.0, 4.21.z
  • bug has dependents
Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jul 27, 2026
@Chandan9112
Chandan9112 force-pushed the backport-node-e2e-4.20 branch 3 times, most recently from 9cbe115 to e1023f3 Compare July 27, 2026 12:28
…-4.20

Bulk backport of node_e2e test case migrations from main (OCP 5.0) to
release-4.20. These tests were previously backported to release-4.22
via PR openshift#31306 and to release-4.21 via PR openshift#31426.

New test files added (test/extended/node/node_e2e/):
- container_runtime_config.go: ContainerRuntimeConfig pidsLimit/overlaySize
- image_mirror_set.go: ImageDigestMirrorSet/ImageTagMirrorSet verification
- image_registry_config.go: Image registry allowedRegistries configuration
- initcontainer.go: Init container restart behavior
- netns_cleanup.go: Network namespace cleanup after pod deletion
- node.go: Kubelet log level, cgroupv2 default, devfuse in CRI-O
- pdb_drain.go: PDB 100% minAvailable blocks drain
- probe_termination.go: Probe terminationGracePeriodSeconds

Helper files added:
- node_utils.go: Helper functions (ExecOnNodeWithChroot, WaitForMCP, etc.)
- node_mcp_helpers.go: Custom MCP creation/cleanup helpers (NodeHasCustomRole)
- testdata/node/node_e2e/pod-dev-fuse.yaml: Test fixture for devfuse test

Modified files:
- imagepolicy/imagepolicy.go: Exported GetMCPCurrentSpecConfigName and
  WaitForMCPConfigSpecChangeAndUpdated for cross-package access
- README.md: Updated with latest test documentation
- bindata.go: Regenerated to include new testdata

Reference: openshift#31306 (release-4.22)
Reference: openshift#31426 (release-4.21)
Co-authored-by: Cursor <cursoragent@cursor.com>
@Chandan9112
Chandan9112 force-pushed the backport-node-e2e-4.20 branch from e1023f3 to 245aebe Compare July 27, 2026 13:07
@openshift-ci

openshift-ci Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

@Chandan9112: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify e1023f3 link true /test verify

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Chandan9112

Copy link
Copy Markdown
Contributor Author

/payload-job periodic-ci-openshift-release-main-nightly-4.20-e2e-aws-disruptive-longrunning
/payload-job periodic-ci-openshift-release-main-ci-4.20-e2e-gcp-ovn-techpreview

@openshift-ci

openshift-ci Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

@Chandan9112: trigger 2 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-nightly-4.20-e2e-aws-disruptive-longrunning
  • periodic-ci-openshift-release-main-ci-4.20-e2e-gcp-ovn-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/b930c2b0-89c1-11f1-81b8-35e946ad8d25-0

@Chandan9112

Copy link
Copy Markdown
Contributor Author

@Chandan9112: trigger 2 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-nightly-4.20-e2e-aws-disruptive-longrunning
  • periodic-ci-openshift-release-main-ci-4.20-e2e-gcp-ovn-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/b930c2b0-89c1-11f1-81b8-35e946ad8d25-0

The Test cases are passing in CI.

Hi @cpmeadors , @BhargaviGudi., can you please review and tag the label?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants