OCPBUGS-99916: exclude openshift-debug-* namespaces from best-effort QoS invariant

[mkowalski]

Fixes https://issues.redhat.com/browse/OCPBUGS-99916 (mirror: https://redhat.atlassian.net/browse/OCPBUGS-99916)

oc debug node/<node> run without an explicit namespace creates a transient openshift-debug-<random> namespace for its debug pod. These pods have no resource requests/limits and are best-effort QoS by design — they are not control-plane workloads.

The [sig-auth][Feature:SecurityPenetration] tests (baremetal-gated) run oc debug node/master-0 repeatedly during the parallel conformance suite. When the [sig-arch] Managed cluster should ensure control plane pods do not run in best-effort QoS invariant scan races with one of these pods, it fails:

fail [github.com/openshift/origin/test/extended/operators/qos.go:89]:
1 pods found in best-effort QoS:
openshift-debug-9m92k/master-0-debug-fl67x is running in best-effort QoS

Audit logs confirm causality: the flagged pod was created by system:admin via oc/5.0.0 at 14:03:02, and the invariant test failed at 14:03:04 (prow run 2079493268545998848, Component Readiness regression 44948, triage 658).

The test already excludes ephemeral debug pods in node.DebugNamespace (openshift-machine-config-operator); this PR extends the same isEphemeralDebugPod exclusion to pods in transient openshift-debug-* namespaces.

---

AI-generated content: This PR was created by AI as part of Component Readiness triage duty. Please verify before acting on it.

Summary by CodeRabbit

• Bug Fixes
  • Updated managed-cluster QoS validation to correctly exclude temporary debug pods.
  • Prevents transient debug workloads from being incorrectly flagged during best-effort QoS checks.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

[openshift-ci-robot]

@mkowalski: This pull request references Jira Issue OCPBUGS-99916, which is invalid:

• expected the bug to target the "5.0.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Fixes https://issues.redhat.com/browse/OCPBUGS-99916 (mirror: https://redhat.atlassian.net/browse/OCPBUGS-99916)

oc debug node/<node> run without an explicit namespace creates a transient openshift-debug-<random> namespace for its debug pod. These pods have no resource requests/limits and are best-effort QoS by design — they are not control-plane workloads.

The [sig-auth][Feature:SecurityPenetration] tests (baremetal-gated) run oc debug node/master-0 repeatedly during the parallel conformance suite. When the [sig-arch] Managed cluster should ensure control plane pods do not run in best-effort QoS invariant scan races with one of these pods, it fails:

fail [github.com/openshift/origin/test/extended/operators/qos.go:89]:
1 pods found in best-effort QoS:
openshift-debug-9m92k/master-0-debug-fl67x is running in best-effort QoS

Audit logs confirm causality: the flagged pod was created by system:admin via oc/5.0.0 at 14:03:02, and the invariant test failed at 14:03:04 (prow run 2079493268545998848, Component Readiness regression 44948, triage 658).

The test already excludes ephemeral debug pods in node.DebugNamespace (openshift-machine-config-operator); this PR extends the same isEphemeralDebugPod exclusion to pods in transient openshift-debug-* namespaces.

---

AI-generated content: This PR was created by AI as part of Component Readiness triage duty. Please verify before acting on it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: de3388fd-f574-4823-b209-7835e2dc0f13

📥 Commits

Reviewing files that changed from the base of the PR and between 621e171 and 3623768.

📒 Files selected for processing (1)

• test/extended/operators/qos.go

---

Walkthrough

The managed-cluster QoS test now skips ephemeral oc debug pods in transient openshift-debug-* namespaces, alongside the existing debug namespace exclusion.

Changes

QoS validation filtering

Layer / File(s)	Summary
Exclude transient debug pods test/extended/operators/qos.go	The pod iteration skips pods in openshift-debug-* namespaces when isEphemeralDebugPod identifies them.

Estimated code review effort: 1 (Trivial) | ~5 minutes

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly states the main change: excluding openshift-debug-* namespaces from the best-effort QoS invariant.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The only Ginkgo title in the changed file is static, and this PR only adjusts QoS filtering logic, not test names.
Test Structure And Quality	✅ Passed	The change only adds an extra skip in one existing invariant It block; no resources, waits, or cleanup were added, and failures still use explicit messages.
Microshift Test Compatibility	✅ Passed	PASS: The PR only tweaks an existing QoS test’s pod filter; it adds no new Ginkgo specs or unsupported MicroShift APIs/features.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PASS: This PR only broadens a QoS filter in an existing test; it adds no new Ginkgo test or multi-node/HA assumption, and no SNO guard is required.
Topology-Aware Scheduling Compatibility	✅ Passed	PASS: Change is test-only in qos.go; it only skips ephemeral debug pods in best-effort validation and adds no scheduling, replica, affinity, or nodeSelector logic.
Ote Binary Stdout Contract	✅ Passed	The PR only adds an extra pod-skip condition inside a Ginkgo It block; there are no stdout writes in main/init/TestMain/suite setup code.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	No new e2e test was added; the QoS test only gained a namespace-prefix exclusion and contains no IPv4-specific or external-network assumptions.
No-Weak-Crypto	✅ Passed	Touched code only adds a namespace prefix filter and reuses isEphemeralDebugPod; no weak-crypto APIs or secret/token comparisons are present.
Container-Privileges	✅ Passed	PR only updates a Go e2e test; no container/K8s manifests or privilege settings (privileged, hostPID/network/IPC, allowPrivilegeEscalation, root, SYS_ADMIN) were added.
No-Sensitive-Data-In-Logs	✅ Passed	The PR only adds a namespace-prefix filter and comments in qos.go; no new logging or sensitive fields are introduced.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[mkowalski]

/jira refresh

[openshift-ci-robot]

@mkowalski: This pull request references Jira Issue OCPBUGS-99916, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@mkowalski: This pull request references Jira Issue OCPBUGS-99916, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

Fixes https://issues.redhat.com/browse/OCPBUGS-99916 (mirror: https://redhat.atlassian.net/browse/OCPBUGS-99916)

oc debug node/<node> run without an explicit namespace creates a transient openshift-debug-<random> namespace for its debug pod. These pods have no resource requests/limits and are best-effort QoS by design — they are not control-plane workloads.

The [sig-auth][Feature:SecurityPenetration] tests (baremetal-gated) run oc debug node/master-0 repeatedly during the parallel conformance suite. When the [sig-arch] Managed cluster should ensure control plane pods do not run in best-effort QoS invariant scan races with one of these pods, it fails:

fail [github.com/openshift/origin/test/extended/operators/qos.go:89]:
1 pods found in best-effort QoS:
openshift-debug-9m92k/master-0-debug-fl67x is running in best-effort QoS

Audit logs confirm causality: the flagged pod was created by system:admin via oc/5.0.0 at 14:03:02, and the invariant test failed at 14:03:04 (prow run 2079493268545998848, Component Readiness regression 44948, triage 658).

The test already excludes ephemeral debug pods in node.DebugNamespace (openshift-machine-config-operator); this PR extends the same isEphemeralDebugPod exclusion to pods in transient openshift-debug-* namespaces.

---

AI-generated content: This PR was created by AI as part of Component Readiness triage duty. Please verify before acting on it.

Summary by CodeRabbit

• Bug Fixes
• Updated managed-cluster QoS validation to correctly exclude temporary debug pods.
• Prevents transient debug workloads from being incorrectly flagged during best-effort QoS checks.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[sdodson]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mkowalski, sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• test/extended/operators/OWNERS [mkowalski,sdodson]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-merge-bot]

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

[openshift-ci]

@mkowalski: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-metal-ipi-ovn-ipv6	3623768	link	true	/test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-gcp-ovn	3623768	link	true	/test e2e-gcp-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-trt]

Risk analysis has seen new tests most likely introduced by this PR.
Please ensure that new tests meet guidelines for naming and stability.

New Test Risks for sha: 3623768

Job Name	New Test Risk
pull-ci-openshift-origin-main-e2e-aws-csi	Medium - "External Storage [Driver: ebs.csi.aws.com] [Testpattern: Dynamic PV (block volmode)] volume-modify [FeatureGate:VolumeAttributesClass] [Feature:VolumeAttributesClass] should recover from invalid target VAC by updating PVC to new valid VAC" is a new test, and was only seen in one job.
pull-ci-openshift-origin-main-e2e-aws-csi	Medium - "External Storage [Driver: ebs.csi.aws.com] [Testpattern: Dynamic PV (default fs)] volume-modify [FeatureGate:VolumeAttributesClass] [Feature:VolumeAttributesClass] should recover from invalid target VAC by updating PVC to new valid VAC" is a new test, and was only seen in one job.
pull-ci-openshift-origin-main-e2e-aws-csi	Medium - "External Storage [Driver: ebs.csi.aws.com] [Testpattern: Dynamic PV (xfs)] [Slow] volume-expand Verify if offline PVC expansion works" is a new test, and was only seen in one job.
pull-ci-openshift-origin-main-e2e-aws-csi	Medium - "External Storage [Driver: ebs.csi.aws.com] [Testpattern: Dynamic PV (xfs)] [Slow] volume-expand should resize volume when PVC is edited and the pod is re-created on the same node after controller resize is finished" is a new test, and was only seen in one job.
pull-ci-openshift-origin-main-e2e-aws-csi	Medium - "External Storage [Driver: ebs.csi.aws.com] [Testpattern: Dynamic PV (xfs)] [Slow] volume-expand should resize volume when PVC is edited while pod is using it" is a new test, and was only seen in one job.
pull-ci-openshift-origin-main-e2e-gcp-csi	Medium - "External Storage [Driver: pd.csi.storage.gke.io] [Testpattern: Dynamic PV (xfs)] [Slow] volume-expand Verify if offline PVC expansion works" is a new test, and was only seen in one job.
pull-ci-openshift-origin-main-e2e-gcp-csi	Medium - "External Storage [Driver: pd.csi.storage.gke.io] [Testpattern: Dynamic PV (xfs)] [Slow] volume-expand should resize volume when PVC is edited and the pod is re-created on the same node after controller resize is finished" is a new test, and was only seen in one job.
pull-ci-openshift-origin-main-e2e-gcp-csi	Medium - "External Storage [Driver: pd.csi.storage.gke.io] [Testpattern: Dynamic PV (xfs)] [Slow] volume-expand should resize volume when PVC is edited while pod is using it" is a new test, and was only seen in one job.

New tests seen in this PR at sha: 3623768

• "External Storage [Driver: ebs.csi.aws.com] [Testpattern: Dynamic PV (block volmode)] volume-modify [FeatureGate:VolumeAttributesClass] [Feature:VolumeAttributesClass] should recover from invalid target VAC by updating PVC to new valid VAC" [Total: 1, Pass: 1, Fail: 0, Flake: 0]
• "External Storage [Driver: ebs.csi.aws.com] [Testpattern: Dynamic PV (default fs)] volume-modify [FeatureGate:VolumeAttributesClass] [Feature:VolumeAttributesClass] should recover from invalid target VAC by updating PVC to new valid VAC" [Total: 1, Pass: 1, Fail: 0, Flake: 0]
• "External Storage [Driver: ebs.csi.aws.com] [Testpattern: Dynamic PV (xfs)] [Slow] volume-expand Verify if offline PVC expansion works" [Total: 1, Pass: 1, Fail: 0, Flake: 0]
• "External Storage [Driver: ebs.csi.aws.com] [Testpattern: Dynamic PV (xfs)] [Slow] volume-expand should resize volume when PVC is edited and the pod is re-created on the same node after controller resize is finished" [Total: 1, Pass: 1, Fail: 0, Flake: 0]
• "External Storage [Driver: ebs.csi.aws.com] [Testpattern: Dynamic PV (xfs)] [Slow] volume-expand should resize volume when PVC is edited while pod is using it" [Total: 1, Pass: 1, Fail: 0, Flake: 0]
• "External Storage [Driver: pd.csi.storage.gke.io] [Testpattern: Dynamic PV (xfs)] [Slow] volume-expand Verify if offline PVC expansion works" [Total: 1, Pass: 1, Fail: 0, Flake: 0]
• "External Storage [Driver: pd.csi.storage.gke.io] [Testpattern: Dynamic PV (xfs)] [Slow] volume-expand should resize volume when PVC is edited and the pod is re-created on the same node after controller resize is finished" [Total: 1, Pass: 1, Fail: 0, Flake: 0]
• "External Storage [Driver: pd.csi.storage.gke.io] [Testpattern: Dynamic PV (xfs)] [Slow] volume-expand should resize volume when PVC is edited while pod is using it" [Total: 1, Pass: 1, Fail: 0, Flake: 0]