NO-JIRA: Update minio image to use source with all supported architectures - #31441
NO-JIRA: Update minio image to use source with all supported architectures#31441jubittajohn wants to merge 1 commit into
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
openshift-ci-robot
added
the
jira/valid-reference
|
@jubittajohn: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
Bot
added
the
ready-for-human-review
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThe ChangesMinIO image update
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@test/extended/util/image/image.go`:
- Line 78: Update the MinIO image entry in the image reference map to use the
published versioned tag instead of latest, and update the corresponding matching
testdata reference to keep both values synchronized.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 4e8f8156-7aab-46e1-afbd-bf93a3b178f2
⛔ Files ignored due to path filters (1)
test/extended/util/image/zz_generated.txtis excluded by!**/zz_generated*
📒 Files selected for processing (1)
test/extended/util/image/image.go
|
|
||
| // used by cluster-image-registry-operator e2e tests (S3/Minio endpoint test) | ||
| "quay.io/minio/minio:RELEASE.2025-09-07T16-13-09Z": -1, | ||
| "quay.io/openshifttest/minio:latest": -1, |
There was a problem hiding this comment.
🔒 Security & Privacy | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Inspect the relevant file and surrounding code.
git ls-files test/extended/util/image/image.go
wc -l test/extended/util/image/image.go
sed -n '1,220p' test/extended/util/image/image.go
# Find the lookup helper and callers.
rg -n "LocationFor\\(|quay.io/openshifttest/minio|openshifttest/minio" test/extended -S
# Show just the relevant definitions/call sites with context.
rg -n -C 3 "func .*LocationFor|quay.io/openshifttest/minio" test/extended/util/image/image.go test/extended -SRepository: openshift/origin
Length of output: 15528
🏁 Script executed:
#!/bin/bash
set -euo pipefail
sed -n '1,120p' test/extended/util/image/README.md
sed -n '1,120p' test/extended/util/image/zz_generated.txt
# Inspect how the image mapping is generated/applied.
rg -n -C 3 "func GetMappedImages|GetMappedImages\\(|allowedImages|zz_generated" test/extended/util/image -S
sed -n '80,170p' test/extended/util/image/image.goRepository: openshift/origin
Length of output: 23095
Pin the MinIO image reference to a versioned tag. latest is mutable and disallowed for e2e images; use the published MinIO version here and keep the matching testdata in sync.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@test/extended/util/image/image.go` at line 78, Update the MinIO image entry
in the image reference map to use the published versioned tag instead of latest,
and update the corresponding matching testdata reference to keep both values
synchronized.
|
|
||
| // used by cluster-image-registry-operator e2e tests (S3/Minio endpoint test) | ||
| "quay.io/minio/minio:RELEASE.2025-09-07T16-13-09Z": -1, | ||
| "quay.io/openshifttest/minio:latest": -1, |
There was a problem hiding this comment.
this LGTM, but where exactly are we using this image?
There was a problem hiding this comment.
https://github.com/openshift/cluster-image-registry-operator/pull/1343/changes#diff-c21f359c274101db5057a1bd6116239e8d55bedc25ff3234907dec7670c2da42R23 - here the PR isn't merged. But this will require updatiion as well. cc: @gangwgr
Signed-off-by: jubittajohn <jujohn@redhat.com>
76bdf92 to
d993616
Compare
|
Mirrored the image with right tag |
|
|
||
| // used by cluster-image-registry-operator e2e tests (S3/Minio endpoint test) | ||
| "quay.io/minio/minio:RELEASE.2025-09-07T16-13-09Z": -1, | ||
| "quay.io/openshifttest/minio:latest": -1, |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bertinatto, jubittajohn The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Scheduling required tests: |
|
@jubittajohn: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
3 participants
quay.io/minio/minio:RELEASE.2025-09-07T16-13-09Z quay.io/openshift/community-e2e-images:e2e-quay-io-minio-minio-RELEASE-2025-09-07T16-13-09Z-vEhi3VtwtVplkeun is re-mirrored, since the mirrored image will again be based on the first source image, which is missing some architecture variants.
Summary by CodeRabbit