Skip to content

OCPEDGE-2827: tolerate one NotReady CP node in EnsureNodesReady for degraded TNF #31442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Neilhamza wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −0
Open

OCPEDGE-2827: tolerate one NotReady CP node in EnsureNodesReady for degraded TNF #31442

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions test/extended/node/node_utils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -991,6 +991,19 @@ func GetNotReadyNodes(ctx context.Context, oc *exutil.CLI) ([]string, error) {
func EnsureNodesReady(ctx context.Context, oc *exutil.CLI) {
notReadyNodes, err := GetNotReadyNodes(ctx, oc)
o.Expect(err).NotTo(o.HaveOccurred(), "failed to check node readiness")

if exutil.ClusterDegraded && len(notReadyNodes) == 1 && exutil.IsTwoNodeFencing(ctx, oc.AdminConfigClient()) {
cpNodes, cpErr := getControlPlaneNodes(ctx, oc)
if cpErr == nil {
for _, cp := range cpNodes {
if cp.Name == notReadyNodes[0] {
framework.Logf("Tolerating NotReady control-plane node %s on intentionally degraded TNF cluster", notReadyNodes[0])
return
}
}
}
}
Comment thread
coderabbitai[bot] marked this conversation as resolved.

o.Expect(notReadyNodes).To(o.BeEmpty(),
"Cannot start test: nodes not Ready: %v. Cluster may be recovering from previous test.", notReadyNodes)
}
Expand Down