Skip to content

Remove fullsend integration - #1061

Closed
samanthajayasinghe wants to merge 2 commits into
openshift:masterfrom
samanthajayasinghe:remove-fullsend
Closed

samanthajayasinghe wants to merge 2 commits into
openshift:masterfrom
samanthajayasinghe:remove-fullsend

Conversation

@samanthajayasinghe

@samanthajayasinghe samanthajayasinghe commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Remove the .fullsend/ directory (config, harness, and policy files)
  • Remove the fullsend GitHub workflows (.github/workflows/fullsend.yaml, .github/workflows/fullsend-poll-jira.yml)

Test plan

  • CI passes without the fullsend workflows
  • No references to .fullsend/ remain in the repo

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Removed
    • Automated Jira issue polling and dispatch are no longer available.
    • Comment- and label-triggered triage, coding, and fix workflows have been removed.
    • The /fs-fix-stop pull request command and its related notification are no longer available.

samanthajayasinghe and others added 2 commits November 17, 2026 11:50
Co-Authored-By: Claude Code <noreply@anthropic.com>
Co-Authored-By: Claude Code <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review.

Walkthrough

The change removes the repository’s Fullsend configuration, harness and sandbox policy files, and GitHub Actions workflows for Jira polling and event dispatch.

Changes

Fullsend integration removal

Layer / File(s) Summary
Fullsend configuration and harness definitions
.fullsend/config.yaml, .fullsend/harness/code.yaml, .fullsend/harness/triage.yaml, .fullsend/policies/triage.yaml
Removed the Fullsend roles, agents, harness triggers, Jira environment settings, and triage sandbox policy.
Fullsend workflow entry points
.github/workflows/fullsend-poll-jira.yml, .github/workflows/fullsend.yaml
Removed scheduled Jira polling, event-based Fullsend dispatch, and the /fs-fix-stop job.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Suggested reviewers: geowa4, raphaelbut

Merge Risk: Minimal · up to c87d6

This PR removes the Fullsend integration, including its Jira polling and event-dispatch automation. No concrete merge-blocking risk was found. Confirm that CI passes and that nothing else in the repository still references .fullsend/.

Pre-merge checks: Passed 14

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title "Remove fullsend integration" matches the changeset. The PR deletes the .fullsend/ directory (config, harness, and policy files) and the fullsend GitHub workflows (fullsend.yaml and fullsend…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names Passed The check applies to Ginkgo test titles (It, Describe, Context, When and similar). The reviewed range changes six files, all deletions: .fullsend/config.yaml, .fullsend/harness/code.yaml, `.fullse…
Test Structure And Quality Passed The check applies to Ginkgo test code. This PR contains no Ginkgo test code. The diff range has six deleted files and no added or changed Go files: - .fullsend/config.yaml - .fullsend/harness/code.yam…
Microshift Test Compatibility Passed The check applies only when new Ginkgo e2e tests are added. The PR only deletes files. The changed-file inventory shows six deletions: .fullsend/config.yaml, .fullsend/harness/code.yaml, `.fullsen…
Single Node Openshift (Sno) Test Compatibility Passed The check applies to new Ginkgo e2e tests (It, Describe, Context, When). This PR adds none. The changed-file inventory shows six deleted files only: .fullsend/config.yaml, .fullsend/harness/code.yaml,…
Topology-Aware Scheduling Compatibility Passed The check applies only when deployment manifests, operator code, or controllers are added or modified. This PR changes six files, and all six are deletions (git diff --name-status shows only D ent…
Ote Binary Stdout Contract Passed The check is not applicable to this pull request. The reviewed range deletes six non-Go files: four under .fullsend/ (config, harness, and policy YAML) and two GitHub workflow YAML files. The diff t…
Ipv6 And Disconnected Network Test Compatibility Passed The check applies only when new Ginkgo e2e tests are added. The PR's changed-file inventory (git diff --name-status against the review base) contains only six deletions: .fullsend/config.yaml, .fullse…
No-Weak-Crypto Passed The no-weak-crypto check fails only when the pull request introduces weak cryptography: MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB mode, custom crypto, or non-constant-time secret comparison. The PR ran…
Container-Privileges Passed The check is container-privileges. It flags privileged: true, hostPID, hostNetwork, hostIPC, SYS_ADMIN, root without justification, and allowPrivilegeEscalation: true in container or Kubernetes mani…
No-Sensitive-Data-In-Logs Passed The no-sensitive-data-in-logs check is satisfied. PR #1061 (openshift/osdctl, author samanthajayasinghe) contains only file deletions. The name-status inventory lists six deleted files: .fullsend/conf…
Full details: Title check

Explanation

The title "Remove fullsend integration" matches the changeset. The PR deletes the .fullsend/ directory (config, harness, and policy files) and the fullsend GitHub workflows (fullsend.yaml and fullsend-poll-jira.yml). The title is short, specific, and states the main change. The author's test plan is unchecked, but that does not affect the title assessment.

Full details: Stable And Deterministic Test Names

Explanation

The check applies to Ginkgo test titles (It, Describe, Context, When and similar). The reviewed range changes six files, all deletions: .fullsend/config.yaml, .fullsend/harness/code.yaml, .fullsend/harness/triage.yaml, .fullsend/policies/triage.yaml, .github/workflows/fullsend-poll-jira.yml, and .github/workflows/fullsend.yaml. None is a Go file, and none is a test file. The change adds no Ginkgo test titles and modifies no existing ones, so no test name can violate the check. My follow-up grep for Ginkgo titles in added Go lines failed on a flag error (rg -E is not a regex flag). That failure does not change the result, because the name-status output already shows no .go file in the diff.

Full details: Test Structure And Quality

Explanation

The check applies to Ginkgo test code. This PR contains no Ginkgo test code. The diff range has six deleted files and no added or changed Go files: - .fullsend/config.yaml - .fullsend/harness/code.yaml - .fullsend/harness/triage.yaml - .fullsend/policies/triage.yaml - .github/workflows/fullsend-poll-jira.yml - .github/workflows/fullsend.yaml A search of the added lines in the full diff found no It(, Describe(, Context(, DescribeTable(, Entry(, g.It(, or g.Describe( calls. No new or modified test blocks exist to evaluate against the six quality requirements, including the informing requirement for new It() blocks. The check is inapplicable, so it passes.

Full details: Microshift Test Compatibility

Explanation

The check applies only when new Ginkgo e2e tests are added. The PR only deletes files. The changed-file inventory shows six deletions: .fullsend/config.yaml, .fullsend/harness/code.yaml, .fullsend/harness/triage.yaml, .fullsend/policies/triage.yaml, .github/workflows/fullsend-poll-jira.yml, and .github/workflows/fullsend.yaml. No added or modified line in the diff contains It(, Describe(, Context(, When(, DescribeTable(, or Entry(. No new Ginkgo test exists, so no MicroShift compatibility concern is introduced. The check is inapplicable.

Full details: Single Node Openshift (Sno) Test Compatibility

Explanation

The check applies to new Ginkgo e2e tests (It, Describe, Context, When). This PR adds none. The changed-file inventory shows six deleted files only: .fullsend/config.yaml, .fullsend/harness/code.yaml, .fullsend/harness/triage.yaml, .fullsend/policies/triage.yaml, .github/workflows/fullsend-poll-jira.yml, and .github/workflows/fullsend.yaml. The diff contains no added lines matching It(, Describe(, Context(, or When(. The check is therefore inapplicable and passes. The PR does not introduce any multi-node or HA test assumption.

Full details: Topology-Aware Scheduling Compatibility

Explanation

The check applies only when deployment manifests, operator code, or controllers are added or modified. This PR changes six files, and all six are deletions (git diff --name-status shows only D entries): - .fullsend/config.yaml - .fullsend/harness/code.yaml - .fullsend/harness/triage.yaml - .fullsend/policies/triage.yaml - .github/workflows/fullsend-poll-jira.yml - .github/workflows/fullsend.yaml None of these files is a deployment manifest, operator, or controller. They are Fullsend agent configuration and GitHub Actions CI workflows. The PR adds no pod specs, anti-affinity rules, topology spread constraints, replica counts, node selectors, tolerations, or PodDisruptionBudgets. Removing these files cannot introduce a scheduling constraint that assumes a 3+ control-plane HA topology. The check is therefore inapplicable and passes.

Full details: Ote Binary Stdout Contract

Explanation

The check is not applicable to this pull request. The reviewed range deletes six non-Go files: four under .fullsend/ (config, harness, and policy YAML) and two GitHub workflow YAML files. The diff touches no .go files, so it adds no process-level stdout writes (fmt.Print*, os.Stdout, klog, log.SetOutput) to any OTE binary. The changed-file inventory came from git diff --name-status on the review refs. Nothing in the diff can introduce or change a stdout contract violation.

Full details: Ipv6 And Disconnected Network Test Compatibility

Explanation

The check applies only when new Ginkgo e2e tests are added. The PR's changed-file inventory (git diff --name-status against the review base) contains only six deletions: .fullsend/config.yaml, .fullsend/harness/code.yaml, .fullsend/harness/triage.yaml, .fullsend/policies/triage.yaml, .github/workflows/fullsend-poll-jira.yml, and .github/workflows/fullsend.yaml. No Go files are added or modified, and no It/Describe/Context/When blocks are introduced. The check is therefore inapplicable, and nothing in the PR introduces IPv4 assumptions or external connectivity requirements in e2e tests. The PR author is samanthajayasinghe; the author is not relevant to this check.

Full details: No-Weak-Crypto

Explanation

The no-weak-crypto check fails only when the pull request introduces weak cryptography: MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB mode, custom crypto, or non-constant-time secret comparison. The PR range deletes six files and adds none: - .fullsend/config.yaml - .fullsend/harness/code.yaml - .fullsend/harness/triage.yaml - .fullsend/policies/triage.yaml - .github/workflows/fullsend-poll-jira.yml - .github/workflows/fullsend.yaml The diff contains no added or modified lines (grep '^\+[^+]' returned nothing). A scan for weak-crypto and comparison patterns found no matches. Removing these files cannot introduce weak crypto. Any cryptographic content in the deleted files is removed, not added. No changed behavior creates a failure condition.

Full details: Container-Privileges

Explanation

The check is container-privileges. It flags privileged: true, hostPID, hostNetwork, hostIPC, SYS_ADMIN, root without justification, and allowPrivilegeEscalation: true in container or Kubernetes manifests. Evidence from the reviewed range (refs/coderabbit/pre-merge-check/base to head): - The changed-file inventory shows six deleted files and no added or modified files: .fullsend/config.yaml, .fullsend/harness/code.yaml, .fullsend/harness/triage.yaml, .fullsend/policies/triage.yaml, .github/workflows/fullsend-poll-jira.yml, and .github/workflows/fullsend.yaml. - The diff contains no added lines (+ lines are empty). - No removed lines match any privilege pattern (privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, allowPrivilegeEscalation, runAsUser, root, securityContext, capabilities). The PR introduces no container or Kubernetes manifest changes, and it adds no privilege settings. The deleted files are Fullsend agent configs and GitHub Actions workflows, not container or K8s manifests. The check therefore has no failure condition to match.

Full details: No-Sensitive-Data-In-Logs

Explanation

The no-sensitive-data-in-logs check is satisfied. PR #1061 (openshift/osdctl, author samanthajayasinghe) contains only file deletions. The name-status inventory lists six deleted files: .fullsend/config.yaml, .fullsend/harness/code.yaml, .fullsend/harness/triage.yaml, .fullsend/policies/triage.yaml, .github/workflows/fullsend-poll-jira.yml, and .github/workflows/fullsend.yaml. A scan of the patch for added lines (lines beginning with "+" and not "+++") returned no output. The PR therefore introduces no new logging statements, so it cannot expose secrets, PII, session IDs, or internal hostnames through new logging. Deleted workflow and config files that once referenced Jira credentials are removed, not added, so they create no new exposure in the diff.

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Central YAML; Path: .coderabbit.yaml
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: 39fff14a-8bf6-4ce5-a987-afd916d9d617
Commits

Reviewing files that changed from the base of the PR and between 0c15ef4 and c87d63a.

Files selected for processing: 6

  • .fullsend/config.yaml
  • .fullsend/harness/code.yaml
  • .fullsend/harness/triage.yaml
  • .fullsend/policies/triage.yaml
  • .github/workflows/fullsend-poll-jira.yml
  • .github/workflows/fullsend.yaml
Files with no reviewable changes: 6

  • .fullsend/config.yaml
  • .fullsend/harness/code.yaml
  • .fullsend/harness/triage.yaml
  • .fullsend/policies/triage.yaml
  • .github/workflows/fullsend-poll-jira.yml
  • .github/workflows/fullsend.yaml

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

@openshift-ci

openshift-ci Bot commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign raphaelbut for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant