[需求] 企业CLA签署管理平台优化-1-的开发实现-app-cla-server部分 - #518
Open
fly333sky wants to merge 1 commit into
Open
Conversation
Contributor
Welcome To opensourceways CommunityHey @fly333sky , thanks for your contribution to the community. Bot Usage ManualI'm the Bot here serving you. You can find the instructions on how to interact with me at Here . That means you can comment below every pull request or issue to trigger Bot Commands. Contact GuideIf you have any questions, please contact the SIG: infratructure , |
Contributor
CLA Signature Passfly333sky, thanks for your pull request. All authors of the commits have signed the CLA. 👍 |
Contributor
|
|||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
背景
[需求] 企业CLA签署管理平台优化-1(app-cla-server)· 开发流水线 · 开发预览阶段(代码已推 + 预览已部署 + UT 已补;门禁/对抗由 PR CI 异步跑)
改动内容
feat(cla-all): 代码已符合预期,本轮无改动
判定结论
已有实现(app-cla-server
bfaa74b、app-cla-webui9708cab)完整覆盖 issue #1974 全部三条需求与 design.md 全部改动项,构建通过、单测全绿、无 bug,本轮无需改代码。逐项核对
app-cla-server(对照 design.md 2.3.2 改动清单 10 项)
corp_signing.goFindPage:模糊匹配($or regex+QuoteMeta)、$sort(date↓,_id↓)、project admin_added_date、复合索引buildCorpSigningSearchFilter用regexp.QuoteMeta+$regex/$options:"i"匹配 corp.name 与 rep.email;buildCorpSigningPagePipeline在 $skip 前插入$sort;corpSigningPageProject含 admin_added_date;CorpSigningIndexes新增{link_id:1,date:-1,_id:-1}corp_signing_do.go:fieldAdminAddedDate 常量、DO 字段、toCorpSigningSummary 映射manager.goAddAdmin 写入 admin_added_date=util.Date()CorpSigningSummary增加 AdminAddedDate额外必要改动(设计未列但实现必需):corp_signing_cache.go 缓存层同步 AdminAddedDate、user_do.go 新增 fieldCsId 常量、mongodb.go 新增 mongodbCmdAnd/mongodbCmdRegex 常量、controllers/corp_signing.go swagger 注释更新。
app-cla-webui(对照 design.md 2.3.4 改动清单 2 项)
-),移除 getCorporationInfo 中 sortDate 调用验证结果
app-cla-server
go build ./...→ EXIT 0(通过)go test ./signing/infrastructure/repositoryimpl/ ./signing/adapter/ -v -count=1 -cover→ 全部 PASSapp-cla-webui
pnpm build→ 构建成功pnpm lint→ 3 个 error 均为既有问题(CookieNotice.vue、ForgetAndSendEmail.vue),与本次改动文件无关,base 分支 origin/main 同样存在需求验收对照
UT 文件(已有,本轮未新增)
signing/infrastructure/repositoryimpl/corp_signing_test.go(749 行):覆盖管道构造排序、$or 搜索分支、DO 映射往返、回填(空/正常/查询失败/更新失败)、AddAdmin 写入、filter 组合($and/$or 四种场景)signing/adapter/corp_signing_test.go(111 行):覆盖 ListPage/List 的 AdminAddedDate 透传 + 非法参数相关 Issue
resolve https://github.com/opensourceways/backlog/issues/1974
AI 使用声明
当前 PR 是否有 AI 参与:
/ai-develop-preview