Repository navigation
zlib-ng comp level 5 - #875
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry, I was just about to add this to #874 literally moments before it was merged 🙏
I suggest also changing the compression level from 6 to 5. This makes the tiles slightly bigger, but, still smaller than it was with zlib (i.e. prior to #874). Rather than a 2% decrease, it's looking more like a 1.56% decrease. However, it's still worth it for two reasons. 1. it delivers an additional ~3% speedup to mapnik CPU time, taking the total win from both PRs to 8.7% on x86 and 11.4% on arm. And 2. it has a combined benefit when combined with a PR I have just made to mapnik: mapnik/mapnik#4593. If both of these PRs are merged, the win increases further to -2.25% smaller tiles, in particular because of this commit which writes the PNG rows in larger chunks which allows zlib-ng to compress even better leijurv/mapnik@2b269ea