Remove redundant Update call in PartsCanvasPointerReleased - #2439
Merged
Merged
Conversation
Every edit state already receives Update on press and on every pointer move; the release point only ever differs from the last move point when no move events fired (e.g. a touch tap that slips a few pixels), in which case applying it moves the part without the user dragging it. The final state is committed in End.
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Preserve the final PartPanningState update to avoid visible panning shortfalls.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Removes a redundant release-time update to prevent click/tap part-position drift.
Changes:
- Removes the extra
Updatecall beforeEnd. - Preserves edit finalization through
End.
| File | Review |
|---|---|
OpenUtau/Views/MainWindow.axaml.cs |
Moderate issue (2 votes): retain a final Update for PartPanningState to prevent incomplete middle-button panning. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
keirokeer
added a commit
to keirokeer/OpenUtau-lunai
that referenced
this pull request
Sep 25, 2026
openutau#2433 openutau#2439 openutau#2440) SupportsPhonemeEnvelope on DiffSinger/Enunu/Voicevox; welcome-page hotkey split; drop redundant part Update.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Cleaner alternative to #2409 (fixes the same click track drift).
PartsCanvasPointerReleased called partEditState.Update() with the release point right before End(). Every edit state already gets Update on press and on every pointer move, so the release point only differs from the last processed point when no move events fired (e.g. a touch tap that slips a few pixels) — exactly the case where applying it moves the part without the user dragging.
Behavior notes: