Swing Grid Support - #2487
Open
maiko3tattun wants to merge 5 commits into
Open
Swing Grid Support#2487maiko3tattun wants to merge 5 commits into
maiko3tattun wants to merge 5 commits into
Conversation
added 2 commits
October 3, 2026 21:14
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Swing snapping currently has persisted-state, coordinate-space, split-boundary, keyboard, and zoomed-rendering correctness issues.
Review effort: Balanced
Findings: 11
Open (11)
Convert playhead to part-relative coordinates · New Use the original grid unit for swing phase · New Mark snap division changes as dirty for save tracking · New Initialize swing dialog from saved project swing · New Derive note duration from the snapped tick · New Preserve unsnapped keyboard movement step · New Clamp keyboard movement at the part start · New Preserve unsnapped keyboard resize step · New Avoid double-applying part position when snapping · New Find the last valid swing grid split point · New Clamp split bounds to the swing grid · New
What changed in this PR
Adds persisted swing-grid support across piano-roll rendering and editing.
Changes:
- Adds straight, triplet, and swing grid options with configurable swing amount.
- Centralizes snapping calculations in
MusicMath. - Applies swing snapping to editing, quantization, paste, and playhead operations.
| File | Description |
|---|---|
OpenUtau/Views/SliderDialog.axaml |
Widens numeric value display. |
OpenUtau/Views/NoteEditStates.cs |
Uses swing-aware snapping in edit states. |
OpenUtau/ViewModels/NotesViewModel.cs |
Manages swing settings and snapping operations. |
OpenUtau/Strings/Strings.axaml |
Adds swing menu text. |
OpenUtau/Controls/TickBackground.cs |
Renders swing grid lines. |
OpenUtau/Controls/PianoRoll.axaml.cs |
Updates quantization and keyboard controls. |
OpenUtau/Controls/PianoRoll.axaml |
Binds swing to grid controls. |
OpenUtau.Core/Util/MusicMath.cs |
Implements centralized swing calculations. |
OpenUtau.Core/Ustx/UProject.cs |
Persists grid and swing settings. |
OpenUtau.Core/Editing/NoteBatchEdits.cs |
Adds swing-aware quantization. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Author
|
All issues have been resolved. |
1 task done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

New Feature:
Changes:
Notes: