Repository navigation
Site branding of washr 1.2.1: template, profiles, check lines, floor - #96
Merged
Merged
Conversation
washr 1.2.1 puts a footer with the washr version and a publisher sentence, a navbar link, a community block and the Open Graph image on every package site (openwashdata/washr#145). The review standard mirrors the washr template and reads the organization values from the profiles, so both change in step, or the review flags every refreshed site. The template, the standards file, the fixture and the washr skill's site reference carry the new blocks; both profiles gain home_url, catalog_url, community_text and publisher_text, the GHE values to confirm in the first GHE review; the check script prints the two new advisory docs lines from washr and passes the publisher sentence to it; the floor is 1.2.1 and the version 1.8.0 throughout. The expected report gains two PASS lines, the 19 FAIL + 1 FLAG mapping to D1 to D17 is unchanged, and the cases footer-missing and footer-stale cover the failing lines. Prepared ahead of the CRAN release of washr 1.2.1, which the issue names as the point for the floor bump: the gate on CI needs washr 1.2.1 installable before this merges. Refs #95 Assisted-by: Claude claude-fable-5-1 Claude-Session: https://claude.ai/code/session_0154SimKL2w6hTuq4FaTKNCK
washr 1.2.1 is a GitHub-only release, carried by the next CRAN submission, so the gate and drift workflows take washr from the dev branch on GitHub as they did before 1.2.0 reached CRAN. The README says where reviewers install it from in the meantime. Refs #95 Assisted-by: Claude claude-fable-5-1 Claude-Session: https://claude.ai/code/session_0154SimKL2w6hTuq4FaTKNCK
washr 1.2.2 (openwashdata/washr#148) moved the publisher line from under the README badges to the Citation section and installs the brand's small logo as the package logo. The profiles, their README and the washr skill's references say so. Refs #95 Assisted-by: Claude claude-fable-5-1 Claude-Session: https://claude.ai/code/session_0154SimKL2w6hTuq4FaTKNCK
Refs #95 Assisted-by: Claude claude-fable-5-1 Claude-Session: https://claude.ai/code/session_0154SimKL2w6hTuq4FaTKNCK
washr 1.3.0 keeps the columns a package added to its dictionary and accepts them in its readiness item (openwashdata/washr#151). The check script, the data checklist and the standards file follow; unnamed columns still fail, with a case for them. Refs #95, #39 Assisted-by: Claude claude-fable-5-1 Claude-Session: https://claude.ai/code/session_0154SimKL2w6hTuq4FaTKNCK
Merged
4 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_pkgdown.ymland the standards file gain the navbar link, the community block, the footer with the publisher sentence and the washr version, and the Open Graph lines; both profiles gethome_url,catalog_url,community_textandpublisher_text(the GHE values are to confirm in the first GHE review, as the funding text); the check script prints the two new advisory docs lines from washr; the washr skill's site reference describes the blocks, the fields andupdate_website().footer-missingandfooter-stalecover the failing lines. No checklist item changed.Test plan
bash fixtures/run_gate.sh: both reports match the expected filesbash fixtures/run_cases.sh: 11 cases okbash scripts/lint.sh: cleanscripts/release.sh 1.8.0Refs #95