Skip to content

Site branding of washr 1.2.1: template, profiles, check lines, floor - #96

Merged
larnsce merged 5 commits into
devfrom
feat/washr-1.2.1-site
Nov 1, 2026
Merged

larnsce merged 5 commits into
devfrom
feat/washr-1.2.1-site

Conversation

@larnsce

@larnsce larnsce commented Oct 31, 2026

Copy link
Copy Markdown
Contributor

Summary

  • The review standard follows washr 1.2.1 (Site branding: name washr and its version in the footer and put openwashdata on every package site washr#145): the standard _pkgdown.yml and the standards file gain the navbar link, the community block, the footer with the publisher sentence and the washr version, and the Open Graph lines; both profiles get home_url, catalog_url, community_text and publisher_text (the GHE values are to confirm in the first GHE review, as the funding text); the check script prints the two new advisory docs lines from washr; the washr skill's site reference describes the blocks, the fields and update_website().
  • Floor 1.2.1 and version 1.8.0 throughout. The fixture carries the new blocks and records the washr version, so the expected report gains two PASS lines (19 FAIL + 1 FLAG unchanged), and the cases footer-missing and footer-stale cover the failing lines. No checklist item changed.
  • washr 1.2.1 is a GitHub-only release, so the gate and drift workflows install washr from the dev branch on GitHub until CRAN serves the floor, as before 1.2.0 (deviation recorded on Site branding of washr 1.2.1: template, profile fields, advisory checks and the washr skill reference #95).

Test plan

  • bash fixtures/run_gate.sh: both reports match the expected files
  • bash fixtures/run_cases.sh: 11 cases ok
  • bash scripts/lint.sh: clean
  • Gate and drift workflows green on this branch (washr from GitHub dev)
  • After the merge into dev: release PR dev into main, then scripts/release.sh 1.8.0

Refs #95

washr 1.2.1 puts a footer with the washr version and a publisher
sentence, a navbar link, a community block and the Open Graph image on
every package site (openwashdata/washr#145). The review standard mirrors
the washr template and reads the organization values from the profiles,
so both change in step, or the review flags every refreshed site.

The template, the standards file, the fixture and the washr skill's
site reference carry the new blocks; both profiles gain home_url,
catalog_url, community_text and publisher_text, the GHE values to
confirm in the first GHE review; the check script prints the two new
advisory docs lines from washr and passes the publisher sentence to it;
the floor is 1.2.1 and the version 1.8.0 throughout. The expected
report gains two PASS lines, the 19 FAIL + 1 FLAG mapping to D1 to D17
is unchanged, and the cases footer-missing and footer-stale cover the
failing lines.

Prepared ahead of the CRAN release of washr 1.2.1, which the issue
names as the point for the floor bump: the gate on CI needs washr 1.2.1
installable before this merges.

Refs #95

Assisted-by: Claude claude-fable-5-1
Claude-Session: https://claude.ai/code/session_0154SimKL2w6hTuq4FaTKNCK
washr 1.2.1 is a GitHub-only release, carried by the next CRAN
submission, so the gate and drift workflows take washr from the dev
branch on GitHub as they did before 1.2.0 reached CRAN. The README says
where reviewers install it from in the meantime.

Refs #95

Assisted-by: Claude claude-fable-5-1
Claude-Session: https://claude.ai/code/session_0154SimKL2w6hTuq4FaTKNCK
washr 1.2.2 (openwashdata/washr#148) moved the publisher line from under
the README badges to the Citation section and installs the brand's
small logo as the package logo. The profiles, their README and the washr
skill's references say so.

Refs #95

Assisted-by: Claude claude-fable-5-1
Claude-Session: https://claude.ai/code/session_0154SimKL2w6hTuq4FaTKNCK
washr 1.3.0 keeps the columns a package added to its dictionary and
accepts them in its readiness item (openwashdata/washr#151). The check
script, the data checklist and the standards file follow; unnamed
columns still fail, with a case for them.

Refs #95, #39

Assisted-by: Claude claude-fable-5-1
Claude-Session: https://claude.ai/code/session_0154SimKL2w6hTuq4FaTKNCK
@larnsce
larnsce merged commit 590ae4e into dev Nov 1, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant