Conversation
Commit 2465066 ("modemmanager: always reset the init_eps if not configured") changed the behaviour for an unset 'init_epsbearer' from leaving the modem untouched to clearing the initial EPS bearer on every setup. This is a regression for users upgrading from 24.10: - Modems without support for setting the LTE attach configuration (e.g. Sierra Wireless EM7430) fail the setup with MM_INIT_EPS_BEARER_SET_FAILED and never come up. - Attach settings preloaded by the carrier firmware are wiped. The same commit also removed the explicit 'none' case, so 'none' now silently skips the initial EPS bearer setup, while it cleared it in 24.10. Neither matches the documentation. Make all modes explicit, each naming where the initial EPS bearer settings come from: - modem: leave the settings stored on the modem unchanged (default) - network: set an empty initial EPS bearer, the network assigns the APN; replaces the implicit clear, e.g. after a SIM swap - connection: use the connection options (apn, iptype, ...) - custom: use the init_* options 'none' and 'default' are kept as deprecated aliases for 'modem' and 'connection'. Unknown values fall back to 'modem'. The README now documents the modes and how to clear stale settings manually. Fixes: openwrt#30299 Signed-off-by: Michael Pfeifroth <micpf@westermo.com>
openwrt-ai
reviewed
Oct 2, 2026
| [ "$?" -ne "0" ] && return 1 | ||
| fi | ||
| case "${init_epsbearer:-modem}" in | ||
| "modem"|"none") |
Collaborator
There was a problem hiding this comment.
In 24.10 an explicit none cleared the initial EPS bearer ("none") branch at modemmanager.sh:634),`` which is what network does now. Aliasing `none` to `modem` keeps the post-246506690 skip, so a 24.10 config with `init_epsbearer 'none'` still behaves differently after the upgrade. Is aliasing `none` to `modem` rather than `network` intentional?
Generated by Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📦 Package Details
Maintainer: @feckert
Description:
Commit 2465066 ("modemmanager: always reset the init_eps if not configured", #27391) changed an unset
init_epsbearerfrom leave the modem untouched to clear the initial EPS bearer on every ifup. This is a regression when upgrading from 24.10 to 25.12:LTE attach configuration is unsupported) now fail withMM_INIT_EPS_BEARER_SET_FAILED, and the interface never comes up.nonebranch, sononenow silently skips the setup, while in 24.10 it cleared it. The README and LuCI (which stores''for "none") describe neither behaviour correctly (modemmanager: init_epsbearer=none behavior differs from documentation and breaks EM7430 #30299).I understand the motivation of 2465066 (stale attach settings, e.g. after a SIM swap), so this keeps the clear as an explicit mode instead of the implicit default. Each value now names where the initial EPS bearer settings come from:
modem(default, also when unset)networkconnectionapn,iptype, …)custominit_*optionsnoneanddefaultare kept as deprecated aliases formodemandconnection, so existing configs keep working. Unknown values fall back tomodem. The README documents the modes and the one-shotmmcli -m <modem> --3gpp-set-initial-eps-bearer-settings=""to clear stale settings manually.Fixes #30299
LuCI counterpart: openwrt/luci#9098
🧪 Run Testing Details
Tested the
init_epsbearercase block in isolation (withmmclistubbed) for all values (unset,modem,none,network,connection,default,custom, unknown) and that a failingmmclicall still aborts the setup.✅ Formalities